Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a better warning when user has unregistered #4921

Closed
nepomuc opened this issue Jan 20, 2021 · 3 comments
Closed

Show a better warning when user has unregistered #4921

nepomuc opened this issue Jan 20, 2021 · 3 comments

Comments

@nepomuc
Copy link

nepomuc commented Jan 20, 2021

Bug Description

My desktop app is showing a bunch of people from my address book as Signal contacts, while the Android app shows that they aren't. But going into the conversation view with one of these contacts it says below the name and phone number, that this contact IS using Signal. On the other side in the input field below it says that I can only write unencrypted SMS to this contact.

Steps to Reproduce

It's hard to reproduce, because this seems to be random. But I'm suspecting that it could have something to do with contacts that used to be signed up but aren't any more?

Actual Result:

The desktop app shows Signal contacts who are not and this leads to "Send failed" messages when trying to write to them via the desktop app.

Expected Result:

Contacts that don't use Signal should not be listed in the desktop app OR even better (feature request) should be listed but marked as normal SMS contacts, like it's handled in the android app.

Screenshots

image
image

Platform Info

Signal Version:

v1.39.6

Operating System:

Windows 10 - 64bit

Linked Device Version:

Android: 5.2.3

Link to Debug Log

https://debuglogs.org/395392492ef08a8b02a3fd2eb513c323826f85e8d783bffeb383b61a6f91b530

@scottnonnenberg-signal
Copy link
Contributor

Yes, if a contact unregisters, we won't remove them from Signal Desktop; you'll still see your messages with them. But new messages won't go through. I'm going to close this.

@nepomuc
Copy link
Author

nepomuc commented Jan 28, 2021

But I have never written any messages to these contacts or received any messages from them via Signal yet. You can see that in the first screenshot. Please reopen this issue again.
Also there's a big chance to solve two problems at once here. By fixing this you could also improve the UX significantly in cases when people unregister. The user wouldn't get a unfriendly error but could be informed that the other user is not using Signal any more. Extra points for disabling the input field as well in these cases.

@scottnonnenberg-signal scottnonnenberg-signal changed the title Signal contact in Desktop app is not real Signal contact Show a better warning when user has unregistered Jan 28, 2021
@stale
Copy link

stale bot commented Sep 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants