Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to alter mentions #4656

Closed
1 task done
goibon opened this issue Nov 18, 2020 · 4 comments
Closed
1 task done

Possible to alter mentions #4656

goibon opened this issue Nov 18, 2020 · 4 comments

Comments

@goibon
Copy link

goibon commented Nov 18, 2020

  • I have searched open and closed issues for duplicates

Bug Description

When mentioning someone in a group chat it is possible to alter the name, but it still sends the message as the full original name. I assume that the original intention from the devs was to not allow modification of it, but it would be nice if you could crop it to just the first name.

Steps to Reproduce

  1. Start a mention in a group chat by typing @
  2. Select a member of the chat using tab
  3. Press ⌥ + backspace to delete the name
  4. Type a new name / message
  5. Send the message

Actual Result:

Using ⌥ + backspace it is possible to delete parts of the name or the entire name and as long as the @ character is not deleted, anything you type is still within the mention.
When the message is sent the mention is transformed back into the original full name.

Expected Result:

Since merely pressing backspace (without ⌥) after a mention deletes the entire mention, I would assume that the intended behaviour would be that ⌥ + backspace deletes the entire mention as well.
I would however think it made sense to be able to delete parts of the mention like in Facebook messenger so you have the possibility of sending shorter mentions.
I do not expect to be able to change the mention to a custom name.

Screenshots

In addition to these images I also have a short screen recording of the issue that I can send upon request as I don't think I can attach it here.
image
image
image
image

Platform Info

Signal Version: v1.38.1

Operating System: macOS Catalina (10.15.7)

Linked Device Version: iOS 14.2

Link to Debug Log

https://debuglogs.org/bc47396b3077a71dae13e945fc65353100bda779114e6f58adb6c4d7da1ffd16

@josh-signal
Copy link
Contributor

when you hit send does it send it with the custom message or with the original mention?

@goibon
Copy link
Author

goibon commented Nov 21, 2020

when you hit send does it send it with the custom message or with the original mention?

It sends the original mention. So in the screenshots I have selected "Morten Lindhard Hedegaard" as mention but changed it to "custom message". Once I sent the message the sent message contained the original mention "Morten Lindhard Hedegaard" as seen in the last screenshot.

If you mean what it sent in the actual send request then I don't know 🤔 I have not looked at it with dev tools open

@EvanHahn-Signal
Copy link
Contributor

That makes sense. This seems like both a feature request (to be able to shorten someone's @-mention) and a bug report (you can make weird edits to someone's @-mention). I'll file this as both.

@goibon
Copy link
Author

goibon commented Nov 26, 2020

@EvanHahn-Signal I hope it's not too much to have in one, but I felt like it would look like a duplicate issue if I filed it separately 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants