Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prompt to confirm installation to prevent accidental downgrades #4504

Closed
1 task done
dpsi opened this issue Sep 9, 2020 · 4 comments
Closed
1 task done

Add a prompt to confirm installation to prevent accidental downgrades #4504

dpsi opened this issue Sep 9, 2020 · 4 comments

Comments

@dpsi
Copy link

dpsi commented Sep 9, 2020

  • I have searched open and closed issues for duplicates

Bug Description

Signal's installer does not contain any prompts or dialogs begins to immediately install upon launch. In my situation I accidentally opened an old installer that I had in my downloads folder due to Windows search being Windows search. The older installer overwrote the newer updated install. Upon launching the Signal app, the older version realized something was wrong when the SQL versions didn't match between the library and the schema. A dialog prompts the user to either copy this error message and exit, or to delete all user data.

Steps to Reproduce

  1. be windows search
  2. when user searches 'signal', return the downloaded installer (1.34.5) as the only result instead of the installed application (1.35.1)
  3. out of muscle reflex, user presses enter on keyboard launching old version of installer
  4. signal installs without confirmation
  5. scary message asking you to delete your data

Actual Result:

Older installer happily installs over newer installation resulting in the SQL lib version mismatch.

Expected Result:

The installer should prompt the user to confirm installation.
The installer should warn/prevent users from downgrading.

Platform Info

Signal Version:

1.34.5 to 1.35.1, probably can be reproduced with other versions.

Operating System:

Windows 10 Pro 2004

Linked Device Version:

N/A

Link to Debug Log

This is the error message shown:

Database startup error:

Error: SQL: User version is 21 but the expected maximum version is 20. Did you try to start an old version of Signal?
    at updateSchema ([REDACTED]\app.asar\ts\sql\Server.js:1202:15)
    at async Object.initialize ([REDACTED]\app.asar\ts\sql\Server.js:1250:9)

Additional Information

#2702 might exacerbate this issue.

@scottnonnenberg-signal
Copy link
Contributor

To be very clear, for other people reading this: if, once you see that scary database dialog, you can go back and install the most recent version and things will work again. Assuming you didn't delete all of your data when that database dialog popped up.

@tripflex
Copy link

@scottnonnenberg-signal @scottnonnenberg but this means there's no way to actually downgrade when a release is pushed that has major bugs in it?

#5279
#4067

@indutny-signal
Copy link
Contributor

Unfortunately, this is indeed the case. Database migrations make it impossible to use older Signal Desktop versions after an update. We'll look into resolving the major bugs as soon as possible!

@stale
Copy link

stale bot commented Sep 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants