Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Add error handling for sync message failures #1841

Closed
1 task done
Trolldemorted opened this issue Nov 30, 2017 · 4 comments
Closed
1 task done

[dev] Add error handling for sync message failures #1841

Trolldemorted opened this issue Nov 30, 2017 · 4 comments

Comments

@Trolldemorted
Copy link
Contributor

  • I have searched open and closed issues for duplicates

Bug description

What happens at the moment is perfectly described in #1387

@scottnonnenberg
Copy link
Contributor

So what is the actual feature request here? If a sync message fails, do we continuously retry it? Give you a button to retry?

It would also be helpful if you could provide a couple scenarios which would be helped with this. Is it that your other devices have inconsistent conversation history? Or is it other kinds of sync messages you're concerned with?

@Trolldemorted
Copy link
Contributor Author

So far I am only concerned about synced outgoing text messages for the siblings' conversation history, because S-D can only send those if I am correct (?).

A resend button would suffice, I suppose?

If you ever want to support modifying groups on S-D, you will need to ensure that the group updates will arrive on your sibling devices too. If it silently fails your devices will have a disjoint view of the group.

@GuillaumeAmat
Copy link

I'm experiencing issues on the conversation history. Some messages (sent by me and by my contacts) do not appear on Signal Desktop whereas they are present on my Android phone.

@scottnonnenberg
Copy link
Contributor

@GuillaumeAmat Please enter a new issue describing your behavior, and be sure to include logs from both devices.

@scottnonnenberg scottnonnenberg changed the title Signal-Desktop does not care about sync message failures [dev] Add error handling for sync message failures Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants