Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block typing if max length exceeded #3362

Closed
ghost opened this issue Jun 7, 2015 · 3 comments
Closed

block typing if max length exceeded #3362

ghost opened this issue Jun 7, 2015 · 3 comments

Comments

@ghost
Copy link

ghost commented Jun 7, 2015

When typing a really long message, textsecure used to block the typing when I reached the max length limit. It just happened to me that I exceeded that limit (without noticing) and sent a message that was automatically trimmed while being sent. Please notify the user that the message will be trimmed, or prevent the typing in the first place.
Don't know in which version this problem arose

@ghost
Copy link
Author

ghost commented Jun 7, 2015

Just so you know, when I exceeded the 2000-character limit, the number of remaining characters went below the zero
(I'm not working on a fix anymore)

@McLoo
Copy link
Contributor

McLoo commented Jun 26, 2015

This can easily be reproduce with pasting rather than typing. Paste 3000, get -1000 left and free typing, until something happens to min integer being -2^31 😁

screenshot_2015-06-26-22-43-43

*why can't I figure out such things on a slot machine or cash dispenser? *

Edit: @mcginty you might want to re-un-jank character count indicators 😉

@agrajaghh
Copy link
Contributor

closing in favor of #5146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants