Skip to content

Fixes #13864 - Avoid Changing to same Phone Number #13883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Sagar0-0
Copy link
Contributor

@Sagar0-0 Sagar0-0 commented Jan 6, 2025

Closes #13864

First time contributor checklist

Contributor checklist

  • Device Realme GT NET 3T, Android 14
  • Device Infinix hot 20 Pro, Android 14
  • Virtual device Pixel 8 Pro, Android 14
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Added a toast for this condition, like handled for other cases.
A better way is to disable the button and/or show a text message on the screen instead of showing toasts(For all handled conditions).

@Sagar0-0
Copy link
Contributor Author

Sagar0-0 commented Jan 6, 2025

I hope some CI/CD is already integrated to generate the string resources for other languages. Let me know if those are required to enter manually or not.

@greyson-signal
Copy link
Contributor

This seems reasonable to me, thanks! And yes, we partner with a translation service and get strings regularly translated, that won't be a problem. The change will go out in 7.30, thank you!

greyson-signal pushed a commit that referenced this pull request Jan 16, 2025
@greyson-signal
Copy link
Contributor

Whoops, typo in the commit body prevented me from linking the commit to this PR. This was merged in 6d7247e.

AbandonedCart pushed a commit to SamSprung/Signal-Android that referenced this pull request Jan 31, 2025
Add proper toast message when call link in use.

Reapply "Update our base themes to avoid crashing MaterialAlertDialog."

This reverts commit d1f4797.

Revert "Add missing required material3 dialog theme attribute."

This reverts commit 36d8e75.

Fix various Material3 theming issues.

Update aapt2 gradle hash for windows.

Fix bug with re-opting into PINs.

Update translations and other static files.

Update baseline profile.

Bump version to 7.29.1

Revert to androidx-camera 1.3.4

Improve message validation.

Fix call camera enable on rotation bug.

Fix auth prompt during linked device flow.

Update translations and other static files.

Update baseline profile.

Bump version to 7.29.2

Fix announcement group text link color.

Ended up reorganizing some theme colors too, but didn't change any.

Fix text highlight color.

Fix calendar background color.

Fix bad checkbox color in help fragment.

Fix unread filter visibility.

Update translations and other static files.

Update baseline profile.

Bump version to 7.29.3

Fix review banner background.

Use recommended style for group title search.

Update translations and other static files.

Bump version to 7.29.4

Update to RingRTC v2.49.2

Fix dangling open cursors in AnalyzeDatabaseJob.

Do not include identity message from self in backup.

Update KeepMessageDuration for 1 year to 366 days.

This allows you to see messages that are exactly one year old (like
birthday wishes) as well as accounts for leap year.

Resolves signalapp#13889

Convert tests to Kotlin, remove Hamcrest.

Resolves signalapp#13884

Convert tests from Hamcrest -> AssertK.

Convert StickerTable to kotlin.

Dedupe packs when reading from sticker table.

Fix 1:1 call unknown state validation failure.

Mitigate PNI editor server bug for group member add updates.

Add whoami check for receipt_credentials.

Add wake lock when linking devices.

Ensure that ANR traces are kept within a reasonable size range.

Ensure that backup timestamps are within a certain range.

Mitigate flaky network by retrying link+sync api calls.

Update libsignal to 0.65.0

Enable the SSRE2 capability.

Fix test compilation issues.

Fix expirationTime for call links.

Add ability to cancel a link+sync.

Claim IAP subscription if we detect a payment token mismatch.

Fix DatabaseConsistencyCheck SQL normalizer.

Remove comment about checking for easy label.

Resolves signalapp#13897

Prevent changing to the same phone number.

Fixes signalapp#13864
Resolvse signalapp#13883

Prevent overlapping contact refreshes.

Fixes signalapp#13852
Resolves signalapp#13874

Improve error handling for serialized job data.

Attempt to rebuild the FTS index in DB error handler.

Fix gv2 left group locally bugs in backup and compose.

Prevent calls crashing due to background restrictions.

Notify a user when they link a device.

Validate serviceIds in pinned chats.

Remove unused ToggleRow.enabled flag.

Story Privacy Setting UI issues

Fixes signalapp#13863
Resolves signalapp#13892

Fix cropping on large images.

Add app migration for SSRE2 capability.

Introduce additional logging for group call updates.

Handle nonretryable errors during link + sync.

Fix country picker reproducible builds bug.

Add polling for devices.

Exclude invalid long messages from backups.

Fix incorrect registration challenge handling when requesting verification codes.

Add small system for consolidating archive export errors.

Fix incorrect left group in local state bug.

Fix progress display hiding way before registration navigation.

Fixes signalapp#13850
Closes signalapp#13898

Remove fix group left incorrectly migration job.

Update libsignal to 0.65.1

Add backup support for contact nicknames and notes.

Update to libsignal 0.65.2

Remove bad instrumentation test.

Add backup support for DirectStoryReplyMessages.

Fix do not disturb settings for calls.

Fix header mode when call is reconnecting.

Add date to unlinked dialog.

Improve call tab performance.

Update translations and other static files.

Update baseline profile.

Co-Authored-By: Greyson Parrelli <[email protected]>
Co-Authored-By: Sagar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phone number can be changed to same number
2 participants