Skip to content

core:version tracks python module or specification #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Teque5 opened this issue Sep 14, 2023 · 1 comment · Fixed by #28
Closed

core:version tracks python module or specification #27

Teque5 opened this issue Sep 14, 2023 · 1 comment · Fixed by #28
Labels
good first issue Good for newcomers

Comments

@Teque5
Copy link
Collaborator

Teque5 commented Sep 14, 2023

I believe the core:version key in the global key should be tracking the version number of the SigMF specification. Right now as coded, this python module is inserting the module version (v1.1.3). I suppose we should fix it to v1.1.0 since that's the latest version of SigMF.

Easy PR for new contributor.
@777arc
Copy link
Member

777arc commented Oct 2, 2023

yes please!

@777arc 777arc added the good first issue Good for newcomers label Oct 2, 2023
@argilo argilo mentioned this issue Oct 2, 2023
Merged
@Teque5 Teque5 closed this as completed in #28 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always set core:version to 1.0.0 argilo/sigmf-python
2 participants
@Teque5 @777arc