Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize example-based runtime #503

Closed
zyteka opened this issue Oct 16, 2023 · 0 comments · Fixed by #509
Closed

Optimize example-based runtime #503

zyteka opened this issue Oct 16, 2023 · 0 comments · Fixed by #509
Assignees

Comments

@zyteka
Copy link
Collaborator

zyteka commented Oct 16, 2023

Currently, generating example-based explanations with Pyreal is slightly slower than alternatives because, in order to match with the existing class structures, feature descriptions are applied after-the-fact using ExampleBasedExplanation.apply_feature_descriptions. This is slower than the alternative method of applying feature descriptions to the training dataset at fitting time.

To fix this, the similar examples fitting function should check if feature descriptions are enabled and apply them there, and then apply_feature_descriptions should be updated to be a no-op for similar examples explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant