Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project new subcommand waits for environment to be ready #492

Closed
brokad opened this issue Nov 28, 2022 · 3 comments · Fixed by #503
Closed

project new subcommand waits for environment to be ready #492

brokad opened this issue Nov 28, 2022 · 3 comments · Fixed by #503
Assignees
Labels
Contribution Wanted The community is welcome to collaborate on this issue
Milestone

Comments

@brokad
Copy link
Collaborator

brokad commented Nov 28, 2022

Currently, running cargo shuttle project new returns immediately with a prompt stating the project is creating.

However, the environment is not ready to be deployed to until cargo shuttle project status returns ready. Most times this is not a big deal, but under high load, environment creation can take a minute or so, which can be unexpectedly long and create a bad experience as users don't know when their environment is finally ready.

Maybe it'd be better to hold exiting from project new until the project is ready, continuously updating the prompt with the latest state, and including a spinner to show there is work in progress. This also requires covering the entire state machine of environments.

If users exit early from the prompt, they should be able to go back into the "blocking, continuously updating state" through project status --wait, which should be equivalent.

@brokad brokad added the Contribution Wanted The community is welcome to collaborate on this issue label Nov 28, 2022
@chesedo
Copy link
Contributor

chesedo commented Nov 29, 2022

Thanks for this @brokad. The prefered solution for this should use websockets rather than a polling model (if possible).

I'm wondering if project status --follow won't be more idiomatic?

@brokad
Copy link
Collaborator Author

brokad commented Nov 29, 2022

I'm wondering if project status --follow won't be more idiomatic?

Sure, I'm fine either way. Let's go with --follow.

@guerinoni
Copy link
Contributor

I will try to implement it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Wanted The community is welcome to collaborate on this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants