Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose hostname when cargo shuttle run #350

Closed
tguichaoua opened this issue Sep 22, 2022 · 5 comments
Closed

Choose hostname when cargo shuttle run #350

tguichaoua opened this issue Sep 22, 2022 · 5 comments
Labels
Good First Issue Good for newcomers

Comments

@tguichaoua
Copy link
Contributor

It could be usefull when debuging to host the server not only on the localhost but also on network to allow other devices to send request.
For example vite has a --host flag for this.

  VITE v3.1.3  ready in 399 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: http://192.168.1.100:5173/
@chesedo chesedo added the Good First Issue Good for newcomers label Sep 28, 2022
@0xpwnstar
Copy link

/assign I would like to work on this

@chesedo
Copy link
Contributor

chesedo commented Oct 31, 2022

@0xpwnstar feel free to take it if you are still interested

@joshua-mo-143
Copy link
Member

I've been working on this over the past few days and believe I may have a solution to this problem - just need to do some testing and I will hopefully be able to push a PR if all goes well.

@chesedo
Copy link
Contributor

chesedo commented Dec 28, 2022

@joshua-mo-143 sounds exciting! 🥳

@chesedo
Copy link
Contributor

chesedo commented Jan 26, 2023

This is closed by #565

@chesedo chesedo closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants