-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build incoming services #220
Merged
bmoxb
merged 13 commits into
shuttle-hq:feat/deployer
from
bmoxb:feat/deployer-build-incoming
Jun 27, 2022
Merged
feat: build incoming services #220
bmoxb
merged 13 commits into
shuttle-hq:feat/deployer
from
bmoxb:feat/deployer-build-incoming
Jun 27, 2022
+323
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions with unit tests
Task linked: CU-2h84xfe Building of incoming services |
chesedo
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, getting one step closer 😄
Co-authored-by: Pieter <pieter@chesedo.me>
Many thanks, @chesedo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building of incoming services
Marker Files
The work around that C came up with to avoid the fact that linked libraries were not being properly reloaded was to give each new
.so
file a random name and then use a well-known 'marker file' to indicate the name of the linked library.so
file.Looking at the code of
libloading
(dependency that handles.so
loading for us), thedlopen
is likely the cause of the issue. The man pages state:I'm trying to figure out an a way of either not add a library to the cache or otherwise ignore it.
Notes
error
module..tar.gz
data (flate2
andtar
) and for creating random.so
file names (rand
).