Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: a static/assets folder #189

Closed
chesedo opened this issue May 26, 2022 · 3 comments
Closed

feature: a static/assets folder #189

chesedo opened this issue May 26, 2022 · 3 comments
Assignees
Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers
Milestone

Comments

@chesedo
Copy link
Contributor

chesedo commented May 26, 2022

I want to load some assets like images as well as some static js and css files during runtime. It would be great if shuttle could take a /static folder at the root of my project and make it accessible during runtime

https://discord.com/channels/803236282088161321/965974106652688394/979465252515233802
https://discord.com/channels/803236282088161321/965974106652688394/978711715741057084

@chesedo chesedo added the Good First Issue Good for newcomers label May 30, 2022
@christos-h christos-h added the Contribution Wanted The community is welcome to collaborate on this issue label May 30, 2022
@IceS2
Copy link

IceS2 commented May 30, 2022

Hey folks, how are you?
I'd love to take this task and try to tackle it (=

@chesedo
Copy link
Contributor Author

chesedo commented May 31, 2022

@IceS2 It's all yours.

@brokad do you have any preferences on this?
So far I'm thinking we can allow only one predefined folder. But I've seen the following being used so far:

  • assets
  • static
  • templates
  • public

Or do we allow the users to dynamically choose their folder somehow?

@IceS2 your inputs are welcome if you have any ideas too 😄

@chesedo chesedo assigned marioidival and unassigned IceS2 Jun 17, 2022
@brokad brokad assigned chesedo and unassigned marioidival Nov 29, 2022
@brokad brokad added this to the v0.8.0 milestone Nov 29, 2022
@oddgrd
Copy link
Contributor

oddgrd commented Dec 8, 2022

Closed in #501 🥳

@oddgrd oddgrd closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants