deployer: update logs APIs to fetch the logs from shuttle-logger #1143
+210
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
force-pushed
the
feature/eng-917-update-deployer-to-fetch-the-logs-from-logger
branch
2 times, most recently
from
419c410 to
a7e58e0
Compare
oddgrd
force-pushed
the
feature/eng-917-update-deployer-to-fetch-the-logs-from-logger
branch
from
a7e58e0 to
37c022e
Compare
oddgrd
reviewed
Aug 18, 2023
chesedo
reviewed
Aug 21, 2023
Comment on lines
+36
to
+37
| // The OTLP_ADDRESS env var is useful for setting a localhost address when running deployer locally. | ||
| let otlp_address = std::env::var("OTLP_ADDRESS").unwrap_or(OTLP_ADDRESS.into()); |
oddgrd
reviewed
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updated
get_logsandget_logs_streamdeployer methods to be based onshuttle-logger.This PR is rebased on top of #1139 .
How has this been tested? (if applicable)
N/A, pending on #1139 .