Replies: 1 comment
-
A few of these observations are similar to what I had written down when first investigating shuttle. I thought I would add them here for posterity: #108 (don't ask why I wrote them on a PR I regretted it immediately). |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is a list of little things that make no sense to an outsider. Purely FYI.
Is there a reason why Cargo.lock is included in the repo? If not, I suggest removing it
Examples refer to
shuttle-service = "0.2.4"
which may be few commits behindmain
branch so they fail to build. Ifmain
is always green it may be better to haveshuttle-service = {git = "https://github.com/rimutaka/shuttle.git"}
instead.e2e/README.md looks like a copy-paste from another project (
unveil-service
?). The document made no sense to me. I wanted to look up tests to understand how everything hangs together.Does this examples/rocket/hello-world example work in your dev env as a standalone project? I get an error.
adding the macro name here
makes it compile. What am I missing?
Beta Was this translation helpful? Give feedback.
All reactions