-
Notifications
You must be signed in to change notification settings - Fork 0
Followup go/vcs FromDir change CL to cmd/go/vcs.go. #1
Comments
I want to find some more definitive sources on what constitutes as an "import path" in the context of
The build tool seems to expect schema-less URIs (or relative paths), which would dictate the forward slash. It says that The Go spec has less strict restrictions, as described at https://golang.org/ref/spec#Import_declarations. But we're interested in the definition of "import path" in the context of Thanks to @lramirez and @dominikh for help compiling the above. |
Also, this entire issue is very related to golang/go#11490. |
Created https://golang.org/cl/21345, awaiting review. |
It's been reviewed, need to follow up next. |
Also made https://golang.org/cl/21795, and they're both merged! Woohoo! |
The relevant change in go/vcs is golang/tools@5804fef.
In it, I said:
However, I didn't back that up with any sources, because it was hard to find something concrete, and I was hoping it'd be accepted via common knowledge. At least it should be enough for the
golang.org/x/tools/go/vcs
package. It was, and the change was reviewed with +2 in https://golang.org/cl/18461 and merged, resolving golang/go#7723.I want to follow up that change and apply it to the very similar source in cmd/go/vcs.go file (in
cmd/go
command) wherevcs.FromDir
was originally copied from.Motivation to do that:
x/tools/go/vcs
version intocmd/go
.The text was updated successfully, but these errors were encountered: