Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings still showing in vscode and Rider #1

Closed
rutgersc opened this issue Jul 30, 2022 · 2 comments
Closed

Warnings still showing in vscode and Rider #1

rutgersc opened this issue Jul 30, 2022 · 2 comments

Comments

@rutgersc
Copy link

First of all, thanks for creating this. Such a good idea to enable safe usage of switch, while also being much better explainable to colleagues.

One thing I noticed is that the exhaustiveness warnings still seem to show in some editors like vscode and Rider. Building the project or viewing the file with Visual Studio 2022 suppresses the warnings as expected.

It seems like it's just broken for both of them:

Just thought I would note it here, as it may spare someone that extra effort to google this issue. Feel free to close this if you think it doesn't belong here! :)

@shuebner
Copy link
Owner

shuebner commented Jul 30, 2022

Thank you for the kind words.
And thank you for bringing this up.

I am guilty of considering the dotnet CLI build first, then the Visual Studio development experience ... and nothing else ;-)

As far as I understood your linked issues, there is nothing I can do to fix this.
But I can at least warn people in the README.

Btw, Visual Studio does not by default run diagnostic suppressors when the build is triggered by running a test.
If you have your exhaustiveness diagnostics severity set to error, this will prevent the test from running (unless you do a proper build first).
But at least here you can configure VS to always run analyzers.
I will add that to the README as well.

As soon as I do, I will close this issue.

@shuebner
Copy link
Owner

added to README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants