Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report of SOLID #12

Open
iGioRojas opened this issue Nov 21, 2020 · 0 comments
Open

Report of SOLID #12

iGioRojas opened this issue Nov 21, 2020 · 0 comments

Comments

@iGioRojas
Copy link

HI! this message is for educational purpose.

The Hotel class is full of static methods, maybe you need share those methods. Single Responsibility Principle.

The whole program don't have extension for rooms, if the manager hotel needs change the rules business of rooms, he cannot. For this problem, I would create a interface "rooms" which contains a method that allow keep the extension. Open-Close Principle.

A DoubleRoom doesn't have polymorphism. Liskov Substitution Principle.

The Food class could be used for more of one service, better create a interface "Services" and then microservices for any room in the hotel. Interface Segregation Principle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant