Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore images in image waiters #8

Open
conorbros opened this issue Sep 19, 2023 · 3 comments
Open

Ignore images in image waiters #8

conorbros opened this issue Sep 19, 2023 · 3 comments

Comments

@conorbros
Copy link
Member

If you do not supply an image waiter, docker-compose-runner should just wait for the container status to be running or healthy rather than specifying you need to add it to the image waiters.

This would remove some friction while testing out new docker compose setups and save you some time modifying/searching docker logs for something suitable to regex on.

@rukai
Copy link
Member

rukai commented Sep 19, 2023

I dont think running or healthy indicates that the service is ready to use for any of the databases that we use.
But if you find any that do we might be able to do something like: ImageWaiter { Regex(String), Healthy }

@conorbros
Copy link
Member Author

conorbros commented Sep 19, 2023

any of the databases that we use

The idea is that you would use that option if the container starting and running is enough to continue.

I came onto this use-case because I wanted to run the opensearch dashboard container while testing.

@rukai
Copy link
Member

rukai commented Sep 19, 2023

Ahhh I'm following now. Something that concerns me with this approach is if we change the version of an image we use we will get race conditions without warning. If we ignored the version when matching image names then it would just be the issue of race conditions when we introduce a new image type which might be worth it for the convenience you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants