-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore images in image waiters #8
Comments
I dont think |
The idea is that you would use that option if the container starting and running is enough to continue. I came onto this use-case because I wanted to run the opensearch dashboard container while testing. |
Ahhh I'm following now. Something that concerns me with this approach is if we change the version of an image we use we will get race conditions without warning. If we ignored the version when matching image names then it would just be the issue of race conditions when we introduce a new image type which might be worth it for the convenience you mentioned. |
If you do not supply an image waiter,
docker-compose-runner
should just wait for the container status to be running or healthy rather than specifying you need to add it to the image waiters.This would remove some friction while testing out new docker compose setups and save you some time modifying/searching docker logs for something suitable to regex on.
The text was updated successfully, but these errors were encountered: