Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make patch sizes smaller on Android #2737

Open
eseidel opened this issue Dec 31, 2024 · 0 comments
Open

feat: make patch sizes smaller on Android #2737

eseidel opened this issue Dec 31, 2024 · 0 comments

Comments

@eseidel
Copy link
Contributor

eseidel commented Dec 31, 2024

Same idea as #811 but very different implementation.

On iOS we use our fancy new Dart compiler toolchain to make a patch binary which is maximally similar to a release binary.
On Android, we don't. So Dart's default compiler can end up with very different output between release and patch for very small changes. Thus making our patches bigger than necessary on Android.

The fix here is mostly within shorebird cli itself, since we have the underlying compiler tech, we just have to invoke it on Android.

This should make Android patch sizes consistently smaller. Right now they're sometimes tiny, but sometimes needlessly large as well. After this change they'd always be as small as we were able to make them with our current tech.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Customers
Development

No branches or pull requests

1 participant