-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shorebird preview --app-id {flavor_id}
downloads and runs wrong flavor on iOS
#2549
Comments
Thanks for the report, will look. |
|
Yes I'm using the app id for the flavor (from shorebird.yaml), not the name itself. |
Do you have this problem if you run |
I didn't know that I'd be prompted If I didn't provide |
Interesting! Do you remember why you thought you needed to provide the |
https://docs.shorebird.dev/guides/flavors/android/#preview-the-release |
Awesome, thanks! |
Well, I tried not providing an |
What's interesting is that it doesn't install the current So, currently I've the following app flavors in the console:
When I select to preview the Dev flavor, it installs the |
That definitely sounds like a bug. Let me see if I can reproduce this locally. If you remember the steps you took to get into this scenario, that would be super helpful. Other things that would be helpful:
|
Same steps at the issue. my shorebird.yaml:
Yes, I've the same flavors for both platforms. |
I meant steps to configure the project. I'm trying now, but in case it's not as simple as the following, it'd be good to konw.
|
That's enough to re-produce it. |
You can create same release |
I think you have to create same release version for both flavors to be able to re-produce it. |
Hmm, I did the following and was not able to reproduce:
What'd I miss? |
@bryanoltman Are you using same version |
Yep |
Can you try releasing with:
That’s the only difference I can see. |
Here's what I see:
Everything looks good (note the app IDs in the PatchCheckRequest) |
Can you share the project you created? A link to a github repo would be super helpful |
https://github.com/AhmedLSayed9/flavors |
Thank you! I'm able to reproduce. This looks like an issue with |
This should be fixed in version 1.4.6. Thanks for the repro sample—not sure we would've been able to track down the issue without it! |
Glad to hear! Thanks for your efforts. |
App ID: (2c13f029-59fa-4e67-a044-4e9ecf3e33d9)
Prerequisites
I've 3 flavors (Prod - Dev - Staging)
Steps To Reproduce:
shorebird preview --app-id {flavor_id}
with flavor_id of Dev or Stagingshorebird preview --app-id {flavor_id}
with flavor_id of Prodshorebird preview --app-id {flavor_id}
with flavor_id of Dev or Staging againProd
flavor (even if it's deleted from Shorebird Console) and I can't preview Dev/Staging again.It only occurs on iOS, while on Android it previews the correct flavor.
I've tested this on both simulator and real device and tested it on 2 different apps.
The text was updated successfully, but these errors were encountered: