Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Group: Artifact in render in dropdown control #2070

Closed
tamara-nexus opened this issue Jun 13, 2024 · 3 comments
Closed

Button Group: Artifact in render in dropdown control #2070

tamara-nexus opened this issue Jun 13, 2024 · 3 comments
Labels
bug Things that aren't working right in the library. needs response Waiting for a response or feedback from the user.

Comments

@tamara-nexus
Copy link

tamara-nexus commented Jun 13, 2024

Describe the bug

Strange visual artifact appears when Button Group is used in a Dropdown. We needed to have a button group in a filter panel and we could not find any other control (other than dropdown) to implement this e.g. a special popup panel control or something else.

To Reproduce

Steps to reproduce the behavior:

  1. Add a button group control in a dropdown control
  2. View in browser
  3. Strange line appears centered above buttons

P.S. this does not appear when button group is used directly e.g. in a page

Screenshots

Image 1

Image 2
@tamara-nexus tamara-nexus added the bug Things that aren't working right in the library. label Jun 13, 2024
@claviska claviska added help wanted Ready for a contributor to tackle. good first issue This bug or task is a good first issue for new contributors. labels Jun 13, 2024
@b-d-m-p
Copy link
Contributor

b-d-m-p commented Jul 2, 2024

I am not able to reproduce this "artifact", which I am assuming is the border line in the middle of the button group that extends above the group.

This is what it looks like in my setup.

image
<sl-dropdown>
  <sl-button slot="trigger" caret>Dropdown</sl-button>
  <sl-menu>
	  <sl-menu-item>
		  <sl-button-group label="Alignment">
			  <sl-button>Left</sl-button>
			  <sl-button>Center</sl-button>
			  <sl-button>Right</sl-button>
		  </sl-button-group>
	  </sl-menu-item>
	  <sl-menu-item>Dropdown Item 2</sl-menu-item>
	  <sl-menu-item>Dropdown Item 3</sl-menu-item>
  </sl-menu>
</sl-dropdown>

@tamara-nexus Can you provide an example of your code? It is quite hard to figure out what is going on just by pictures.

Are you using sl-menu & sl-menu-item? I'd imagine leaving those out could cause some unintended renderings.

@b-d-m-p
Copy link
Contributor

b-d-m-p commented Jul 2, 2024

I tried taking out sl-menu & sl-menu-item but I still didn't get the artifact. 🤔

@claviska claviska added needs response Waiting for a response or feedback from the user. and removed help wanted Ready for a contributor to tackle. good first issue This bug or task is a good first issue for new contributors. labels Jul 2, 2024
@claviska
Copy link
Member

Closing due to no response. If you're still having trouble with this, feel free to comment with an example and we'll reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library. needs response Waiting for a response or feedback from the user.
Projects
None yet
Development

No branches or pull requests

3 participants