Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve sf 7 deprecation #97

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Aug 7, 2024

Hi,

I tried this lib with SF7 and got a deprecation,

The "Symfony\Component\HttpKernel\DependencyInjection\Extension" class is considered internal since Symfony 7.1, to be deprecated in 8.1; use Symfony\Component\DependencyInjection\Extension\Extension instead. It may change without further notice. You should not use it from "Shivas\VersioningBundle\DependencyInjection\ShivasVersioningExtension".

This PR solve it, and since the file exist in 5.4 versions, it will still be compatible with every SF 7 versions.

Closes #96

@VincentLanglet
Copy link
Contributor Author

Friendly ping @shivas @dontub.

A patch release with this PR would be really helpful for our migration 🙏

@dontub dontub merged commit fd89e35 into shivas:master Aug 14, 2024
14 checks passed
@dontub
Copy link
Collaborator

dontub commented Aug 14, 2024

Thanks @VincentLanglet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symfony 7.1 deprecation
2 participants