Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 4.4 / Twig 3 compatibility #62

Closed
mikatrash opened this issue Nov 21, 2019 · 1 comment
Closed

Symfony 4.4 / Twig 3 compatibility #62

mikatrash opened this issue Nov 21, 2019 · 1 comment

Comments

@mikatrash
Copy link
Contributor

Hi,

We encountered this issue since we updated to SF4.4.
Twig's GlobalInterface is TypeHinted (twigphp/Twig@54cec4e#diff-08b21707843379a1fde275ef7f0a2b49) so VersionExtension doesn't implement the interface.

Declaration of Shivas\VersioningBundle\Twig\VersionExtension::getGlobals() must be compatible with Twig\Extension\GlobalsInterface::getGlobals(): array in C:\WorkspacesEclipse\TRUNK\eLogikSupport\vendor\shivas\versioning-bundle\Twig\VersionExtension.php on line 12
@mikatrash mikatrash mentioned this issue Nov 21, 2019
Merged
@mikatrash mikatrash changed the title Symfony 4.4 / Twig compatibility Symfony 4.4 / Twig 3 compatibility Nov 21, 2019
@dontub
Copy link
Collaborator

dontub commented Nov 21, 2019

Fixed by #63.

@dontub dontub closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikatrash @dontub