Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure COMPOSER_PROCESS_TIMEOUT #811

Closed
1 task done
Bilge opened this issue Jan 17, 2024 · 4 comments
Closed
1 task done

Configure COMPOSER_PROCESS_TIMEOUT #811

Bilge opened this issue Jan 17, 2024 · 4 comments
Assignees
@shivammathur
Labels
enhancement New feature or request

Comments

@Bilge
Copy link

Bilge commented Jan 17, 2024

Describe the feature
Configure COMPOSER_PROCESS_TIMEOUT.

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue
I just had two composer test jobs fail on GitHub Actions after a 6 hours timeout (the maximum allowed), burning through 720 minutes of allowance for no reason, all because this action quietly disables the timeout feature entirely. This is not safe or a good idea; the timeout is enabled by default for good reason. Regardless of whether you agree, this should be configurable.

Describe alternatives
I could probably manually override the timeout in each step or command where I require the timeout, though doing so would be laborious and hacky.

Are you willing to submit a PR?
No, I don't know TypeScript or how to test actions in development.
@Bilge Bilge added the enhancement New feature or request label Jan 17, 2024
@shivammathur
Copy link
Owner

I would not change it as that would be a breaking change, but support for COMPOSER_PROCESS_TIMEOUT env can be added.

@Bilge Bilge changed the title Configure COMPOSER_PROCESS_TIMEOUT Configure COMPOSER_PROCESS_TIMEOUT Jan 17, 2024
@Bilge
Copy link
Author

Bilge commented Jan 26, 2024

Yes, that is what I was driving at.

@shivammathur
Copy link
Owner

Added support in a6ce3f5. Will be in next release.

@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Feb 22, 2024
@shivammathur
Copy link
Owner

Released in 2.30.0.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivammathur shivammathur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bilge @shivammathur