Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail build step if tools installation fails #652

Closed
1 task done
kevinpapst opened this issue Oct 9, 2022 · 4 comments
Closed
1 task done

Fail build step if tools installation fails #652

kevinpapst opened this issue Oct 9, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@kevinpapst
Copy link

kevinpapst commented Oct 9, 2022

Describe the feature
I am currently in a situation where symfony-cli installation fails out of nowhere.
In that case obviously something in the later build steps will fail, but the cause is hidden, as Setup-PHP reports being successful.

I would prefer if Setup PHP fails, if any of the requested installations steps fail.

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue
Something went wrong with symfony-cli.

Describe alternatives
Manual check all steps for the cause of the failure

Additional context
Bildschirmfoto 2022-10-09 um 13 18 11

Here is the build link:
https://github.com/kevinpapst/kimai2/actions/runs/3213939983/jobs/5253975481

Btw: I don't want to make this issue about the symfony-cli, but I think it fails since the latest release of Symfony-Cli one hour ago. See https://github.com/symfony-cli/symfony-cli/releases - maybe there is something broken now?

@kevinpapst kevinpapst added the enhancement New feature or request label Oct 9, 2022
@shivammathur
Copy link
Owner

You can specify fail-fast: true environment variable to make it fail.
https://github.com/shivammathur/setup-php#fail-fast-optional

symfony-cli is failing because they keep changing how they release this tool, this time the Linux release artifacts without the version are missing. I will fix it in the next release to use the versioned ones.

@kevinpapst
Copy link
Author

Tried fail-fast - works 👍
Thanks for helping me to find the right place in the docs.

As now my CI pipeline is broken, and from tomorrow one a lot more: I guess you are releasing soon?!

@shivammathur
Copy link
Owner

It should work now as the change was reverted upstream

@kevinpapst
Copy link
Author

Awesome, I can confirm: the broken builds do work after a "Re-run".
Thank you @shivammathur for taking the action, you do an amazon job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants