Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 6, 2025

Description

Enable and fixes ST1005 rule from staticcheck

@mmorel-35 mmorel-35 force-pushed the staticcheck/ST1005 branch from 77eaa43 to f97870b Compare May 6, 2025 05:12
@mmorel-35 mmorel-35 force-pushed the staticcheck/ST1005 branch from f97870b to 7ec1e8a Compare May 6, 2025 05:22
@mmorel-35 mmorel-35 force-pushed the staticcheck/ST1005 branch 2 times, most recently from 3718edc to 3f1d7be Compare May 6, 2025 05:30
@mmorel-35 mmorel-35 marked this pull request as ready for review May 6, 2025 05:36
@mmorel-35 mmorel-35 force-pushed the staticcheck/ST1005 branch from 3f1d7be to 16856e2 Compare May 7, 2025 06:06
@mmorel-35 mmorel-35 force-pushed the staticcheck/ST1005 branch from 16856e2 to 71c7439 Compare May 7, 2025 06:09
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The failed tests are related to #1849.

@shirou shirou merged commit 15eaecd into shirou:master May 8, 2025
48 of 52 checks passed
@mmorel-35 mmorel-35 deleted the staticcheck/ST1005 branch May 8, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants