Merge pull request #1205 from mmorel-35/master

enable more linters, report coverage and cache mods

Author: shirou

.github/workflows/build_test.yml

@@ -13,6 +13,18 @@ jobs:
         go-version: ${{ matrix.go-version }}
     - name: Checkout code
       uses: actions/checkout@v2
+    - id: cache-paths
+      run: |
+        echo "::set-output name=cache::$(go env GOCACHE)"
+        echo "::set-output name=mod-cache::$(go env GOMODCACHE)"
+    - name: Cache go modules
+      uses: actions/cache@v2
+      with:
+        path: |
+          ${{ steps.cache-paths.outputs.cache }}
+          ${{ steps.cache-paths.outputs.mod-cache }}
+        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+        restore-keys: ${{ runner.os }}-go-
     - name: Build Test v3
       run: |
-        make build_test
+        make build_test

.github/workflows/test.yml

@@ -14,6 +14,25 @@ jobs:
         go-version: ${{ matrix.go-version }}
     - name: Checkout code
       uses: actions/checkout@v2
+    - id: go-env
+      run: |
+        echo "::set-output name=cache::$(go env GOCACHE)"
+        echo "::set-output name=mod-cache::$(go env GOMODCACHE)"
+    - name: Cache go modules
+      uses: actions/cache@v2
+      with:
+        path: |
+          ${{ steps.go-env.outputs.cache }}
+          ${{ steps.go-env.outputs.mod-cache }}
+        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+        restore-keys: ${{ runner.os }}-go-
     - name: Test
       run: |
-        go test ./...
+        go test -coverprofile='coverage.out' -covermode=atomic ./...
+    - name: Upload Code Coverage
+      uses: codecov/codecov-action@v2
+      with:
+        fail_ci_if_error: true
+        files: coverage.out
+        flags: ${{ runner.os }},go-${{ matrix.go-version }}
+        token: ${{ secrets.CODECOV_TOKEN }}

.golangci.yml

@@ -1,9 +1,35 @@
+issues:
+  max-same-issues: 0
+  exclude-rules: 
+  - linters: 
+    - gosec
+    text:  "G204"
+  - linters: 
+    - revive
+    text:  "var-naming"
+  - linters: 
+    - revive
+    text:  "exported"
 linters:
   enable:
+    - asciicheck
+    - durationcheck
     - errorlint
     - gci
+    - gofmt
+    - gofumpt
+    - goimports
+    - gosec
     - gosimple
+    - importas
+    - megacheck
+    - misspell
+    - nakedret
+    - nolintlint
+    - predeclared
+    - revive
     - typecheck
+    - unparam
   disable:
     - deadcode
     - errcheck

_tools/v3migration/v3migration.go

@@ -103,5 +103,4 @@ func main() {
 			issueRemoveUnusedValue()
 		}
 	}
-
 }

cpu/cpu.go

@@ -51,8 +51,10 @@ type lastPercent struct {
 	lastPerCPUTimes []TimesStat
 }
 
-var lastCPUPercent lastPercent
-var invoke common.Invoker = common.Invoke{}
+var (
+	lastCPUPercent lastPercent
+	invoke         common.Invoker = common.Invoke{}
+)
 
 func init() {
 	lastCPUPercent.Lock()

cpu/cpu_aix.go

@@ -1,3 +1,4 @@
+//go:build aix
 // +build aix
 
 package cpu
@@ -36,9 +37,9 @@ func TimesWithContext(ctx context.Context, percpu bool) ([]TimesStat, error) {
 		}
 		ct := &TimesStat{
 			CPU:    "cpu-total",
-			Idle:   float64(c.IdlePct), 
-			User:   float64(c.UserPct), 
-			System: float64(c.KernPct), 
+			Idle:   float64(c.IdlePct),
+			User:   float64(c.UserPct),
+			System: float64(c.KernPct),
 			Iowait: float64(c.WaitPct),
 		}
 		ret = append(ret, *ct)
@@ -56,11 +57,11 @@ func InfoWithContext(ctx context.Context) ([]InfoStat, error) {
 		return nil, err
 	}
 	info := InfoStat{
-		CPU: 0,
-		Mhz: float64(c.ProcessorHz / 1000000),
+		CPU:   0,
+		Mhz:   float64(c.ProcessorHz / 1000000),
 		Cores: int32(c.NCpusCfg),
-		}
-	result := []InfoStat{info};
+	}
+	result := []InfoStat{info}
 	return result, nil
 }
 
@@ -71,4 +72,3 @@ func CountsWithContext(ctx context.Context, logical bool) (int, error) {
 	}
 	return c.NCpusCfg, nil
 }
-

cpu/cpu_darwin.go

@@ -1,3 +1,4 @@
+//go:build darwin
 // +build darwin
 
 package cpu

cpu/cpu_darwin_cgo.go

@@ -1,5 +1,5 @@
-// +build darwin
-// +build cgo
+//go:build darwin && cgo
+// +build darwin,cgo
 
 package cpu
 
@@ -108,5 +108,4 @@ func allCPUTimes() ([]TimesStat, error) {
 	}
 
 	return []TimesStat{c}, nil
-
 }

cpu/cpu_darwin_nocgo.go

@@ -1,5 +1,5 @@
-// +build darwin
-// +build !cgo
+//go:build darwin && !cgo
+// +build darwin,!cgo
 
 package cpu
 

cpu/cpu_dragonfly.go

@@ -15,14 +15,16 @@ import (
 	"golang.org/x/sys/unix"
 )
 
-var ClocksPerSec = float64(128)
-var cpuMatch = regexp.MustCompile(`^CPU:`)
-var originMatch = regexp.MustCompile(`Origin\s*=\s*"(.+)"\s+Id\s*=\s*(.+)\s+Stepping\s*=\s*(.+)`)
-var featuresMatch = regexp.MustCompile(`Features=.+<(.+)>`)
-var featuresMatch2 = regexp.MustCompile(`Features2=[a-f\dx]+<(.+)>`)
-var cpuEnd = regexp.MustCompile(`^Trying to mount root`)
-var cpuTimesSize int
-var emptyTimes cpuTimes
+var (
+	ClocksPerSec   = float64(128)
+	cpuMatch       = regexp.MustCompile(`^CPU:`)
+	originMatch    = regexp.MustCompile(`Origin\s*=\s*"(.+)"\s+Id\s*=\s*(.+)\s+Stepping\s*=\s*(.+)`)
+	featuresMatch  = regexp.MustCompile(`Features=.+<(.+)>`)
+	featuresMatch2 = regexp.MustCompile(`Features2=[a-f\dx]+<(.+)>`)
+	cpuEnd         = regexp.MustCompile(`^Trying to mount root`)
+	cpuTimesSize   int
+	emptyTimes     cpuTimes
+)
 
 func init() {
 	clkTck, err := sysconf.Sysconf(sysconf.SC_CLK_TCK)