Status: Colorize bluetooth icons (16px-24px) #468
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use full-color icons for bluetooth. These icons match the rest of the color theme better and are easier to see in both light and dark themes. Using full-color icons for these lower sizes now matches the look of the existing bluetooth icons at 32px and above. Remove monochromatic bluetooth icons from the `panel` folder. Symbolic icons (which automatically recolorize) are now common so these monochromatic icons should no longer be needed. In places where developers have chosen not to use symbolic icons, we shouldn't force the look. This also solves an issue where the monochromatic icons were difficult to see with mixed light and dark themes (especially with per-app light and dark theme preferences becoming more common).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might hold of merging these "colorize status icon" PRs for a little while. I'd rather get more of them ready and do them at once so it doesn't feel broken or incomplete with some color and some monochromatic.
More testing is probably needed on these to make sure they work across DEs. It will also give time for some user feedback.
Might try to complete a HiDPI option before merging so that there will exist a HiDPI version with the monochromatic panel icons. For those who prefer them, a HiDPI version including them will give them a lot more longevity.
Use full-color icons for bluetooth. These icons match the rest of the color theme better and are easier to see in both light and dark themes. Using full-color icons for these lower sizes now matches the look of the existing bluetooth icons at 32px and above.
Remove monochromatic bluetooth icons from the
panelfolder. Symbolic icons (which automatically recolorize) are now common so these monochromatic icons should no longer be needed. In places where developers have chosen not to use symbolic icons, we shouldn't force the look. This also solves an issue where the monochromatic icons were difficult to see with mixed light and dark themes (especially with per-app light and dark theme preferences becoming more common).