Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status: Colorize volume icons #467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

newhoa
Copy link
Contributor

@newhoa newhoa commented Jun 30, 2024

@ochosi, if you could take a quick look at the "colorize volume" and "colorize battery" PRs I'd appreciate it. I'd like to make sure you're okay with continuing the colorization of the status icons.

This is something we talked about a year or two ago a few times (like here). We kind of already started this with coloring the Wifi icons but just wanted to make sure it's still an okay direction.

If developers want symbolic icons, they now have that option in Gtk3+ and Qt5+. If they don't then we should honor their design. Non-symbolic icons being all color gives a more consistent user experience.

Ultimately I think it will lead to being able to get rid of the -dark variant, as icons will be legible in light and dark themes.

Current:
current-light2

Proposed:

prop-light2

prop-dark2


Use full color icons for volume. These icons match the rest of the color theme better and are easier
to see in both light and dark themes.

Remove same-named monochromatic icons from the panel folder. Symbolic icons (which automatically recolorize) are now common so these monochromatic icons should no longer be needed. In places where developers have chosen not to use symbolic icons, we shouldn't force the look. This also solves an issue where the monochromatic icons were difficult to see with mixed light and dark themes (especially with per-app
light and dark theme preferences becoming more common).

Symlink -panel suffixed icons to the new
colorized icons at 16px, 22px. These still
may be used for ayatana indicators. Not sure
if any sizes other than 22px really needed.

Fixes #416
Fixes #90
Address part of #362
Addresses part of #346
Newer solution to #180

Use full color icons for volume. These icons match
the rest of the color theme better and are easier
to see in both light and dark themes.

Remove same-named monochromatic icons from the `panel` folder.
Symbolic icons (which automatically recolorize) are now common
so these monochromatic icons should no longer be needed.
In places where developers have chosen not to use symbolic icons,
we shouldn't force the look. This also solves an issue where
the monochromatic icons were difficult to see with mixed
light and dark themes (especially with per-app
light and dark theme preferences becoming more common).

Symlink `-panel` suffixed icons to the new
colorized icons at 16px, 22px. These still
may be used for ayatana indicators. Not sure
if any sizes other than 22px really needed.

Fixes shimmerproject#416
Fixes shimmerproject#90
Address part of shimmerproject#362
Addresses part of shimmerproject#346
Newer solution to shimmerproject#180
Copy link
Member

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, that totally makes sense. Thanks for working this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing icons for sound and network Wrong audio-volume icons for elementary-xfce-dark theme
2 participants