Status: Colorize battery icons (16px-24px) #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use full-color icons for battery. These icons match the rest of the color theme better and are easier to see in both light and dark themes. Using full-color icons for these lower sizes now matches the look of the battery icons at 32px and above. Remove monochromatic battery icons from the `panel` folder. Symbolic icons (which automatically recolorize) are now common so these monochromatic icons should no longer be needed. In places where developers have chosen not to use symbolic icons, we shouldn't force the look. This also solves an issue where the monochromatic icons were difficult to see with mixed light and dark themes (especially with per-app light and dark theme preferences becoming more common). Add symlinks for `gpm-` prefixed icons (used by MATE Power Manager). Re-add previously removed symlinks for old legacy upower names (`battery-020`, etc) which are still used in some apps and desktops. Add missing `ac-adapter` and `battery-missing` icons used by some apps, including Xfce Power Manager.
ochosi
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this covers switching over from monochrome to color while still keeping the same support for other DEs. But it is a big change so it may still need a little testing on a few DEs before merge to make sure. Any testers would be appreciated!
Use full-color icons for battery. These icons match the rest of the color theme better and are easier
to see in both light and dark themes. Using full-color icons for these lower sizes now matches the look of the battery icons at 32px and above.
Remove monochromatic battery icons from the
panelfolder. Symbolic icons (which automatically recolorize) are now common so these monochromatic icons should no longer be needed. In places where developers have chosen not to use symbolic icons, we shouldn't force the look. This also solves an issue where the monochromatic icons were difficult to see with mixed light and dark themes (especially with per-applight and dark theme preferences becoming more common).
Add symlinks for
gpm-prefixed icons (used by MATE Power Manager). Re-add previously removed symlinks for old legacy upower names (battery-020, etc) which are still used in some apps and desktops.Add missing
ac-adapterandbattery-missingicons used by some apps, including Xfce Power Manager.