Remove inherited themes from index.theme #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FreeDesktop.org Icon Theme Spec has been updated stating that inherited themes should be present on the system (considered dependencies). The currently listed themes in elementary-xfce's `Inherits` line are either no longer developed and missing modern icons (gnome), or have reduced the scope of their theme to focus on their OS (Adwaita, elementary). elementary-xfce should currently be robust enough that it should already include the icons found in these themes. So it no longer seems very necessary to keep these, and removing them will prevent unnecessary themes from being forced as dependencies for users who may not want them. Fixes shimmerproject#458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FreeDesktop.org Icon Theme Spec has been updated stating that inherited themes should be present on the system (considered dependencies).
The currently listed themes in elementary-xfce's
Inheritsline are either no longer developed and missing modern icons (gnome), or have reduced the scope of their theme to focus on their OS (Adwaita, elementary).elementary-xfce should currently be robust enough that it should already include the icons found in these themes. So it no longer seems very necessary to keep these, and removing them will prevent unnecessary themes from being forced as dependencies for users who may not want them.
Fixes #458