Skip to content

Conversation

@theycallmejeano
Copy link

@theycallmejeano theycallmejeano commented May 2, 2022

Description

  • Adds a merge option to the csv output that allows the user to merge the results from multiple username searches into one file
  • Adds a no--txt argument to suppress the creation of the txt file

Screenshots

Checking for output : csv merge, no txt
python3 sherlock barackobama michelleobama --csv --merge results/obamas_test --no-txt --site Facebook --site Twitter
image

Without merging or suppressing txt
python3 sherlock barackobama michelleobama --site Facebook --site Twitter --csv
image

How Has This Been Tested?

  • Ran given unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@theycallmejeano theycallmejeano marked this pull request as draft May 6, 2022 05:37
@theycallmejeano theycallmejeano marked this pull request as ready for review May 6, 2022 05:37
@theycallmejeano
Copy link
Author

Hi @sdushantha, I was unable to tag a reviewer for this.
Thanks for sharing this tool. I've been using it for ~2 years and its served me well. I'm proposing this argument to the csv feature, to allow for output from multiple userames to be merged in one file. I found it helpful when searching for multiple usernames.

Happy to hear your thoughts on this

@sdushantha sdushantha added the enhancement New feature or request label May 14, 2022
Copy link
Collaborator

@matheusfelipeog matheusfelipeog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A series of issues have addressed this in some way: #2263 #2602 #2603

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants