Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

differences with Mnih #13

Open
rola93 opened this issue Feb 9, 2017 · 0 comments
Open

differences with Mnih #13

rola93 opened this issue Feb 9, 2017 · 0 comments

Comments

@rola93
Copy link

rola93 commented Feb 9, 2017

Hello! according to Mnih, the function phi applies a preprocessing to the last 4 frames of a history and stacks them to produce the input to the Q function, however, reading your code I understand that it only feeds one raw frame to the Q network. Am I right?

I also found in dqn.py, the procedure iterate(self), it has a for which says:
episode = random.randint(max(0, N-50), N-1)

shouldn't this be N-self.memory instead of N-50?

This is my first interaction here, hope you understand 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant