Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion in docs about if backtrace feature is enabled by default #197

Open
scrabsha opened this issue Nov 16, 2019 · 3 comments
Open

Confusion in docs about if backtrace feature is enabled by default #197

scrabsha opened this issue Nov 16, 2019 · 3 comments
Labels
found in the field A user of SNAFU found this when trying to use it support request Help requested on using the project

Comments

@scrabsha
Copy link

Hello,
There are two information about the default state of the backtrace feature.

As such, one of these two pages is wrong. I am no expert in how features are declared in Cargo.toml, but I think the default behaviour is backtrace disabled by default.

If this issue is accepted, then I'll be very happy to provide you a PR to fix the documentation.

@shepmaster
Copy link
Owner

snafu::Backtrace page says it is enabled by default,

It does not say that; it actually says (emphasis mine)

Backtrace functionality is currently enabled.

“Currently” does not mean “default“. Could you suggest another wording that would be more understandable?

@shepmaster shepmaster changed the title Confusion in docs about wether if backtrace feature is enabled Confusion in docs about if backtrace feature is enabled by default Nov 16, 2019
@shepmaster shepmaster added found in the field A user of SNAFU found this when trying to use it support request Help requested on using the project labels Nov 16, 2019
@scrabsha
Copy link
Author

Wow sorry, I though the documentation system in cargo is static and is always the same, no matter the features selected. Generating custom documentation according to feature flags is a very nice idea!

This confused me because I was reading online documentation, so "currently" had no sense to me.

Unfortunately, my english level is not that high, so the best way to me to say it would be:

This documentation was compiled with Backtrace functionality enabled.

This is a way heavier style, but that's the best idea I have. It would allow someone with low experience, reading online, not to make my mistake.

However, I don't think my suggestion worth the cost: as you pointed out, it was a misunderstanding from my part and not a confusion from the documentation.

@shepmaster
Copy link
Owner

It's worth pointing out that we enable non-default features on docs.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
found in the field A user of SNAFU found this when trying to use it support request Help requested on using the project
Projects
None yet
Development

No branches or pull requests

2 participants