Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appraisal Specific Target Selection #75

Open
Eein opened this issue Sep 12, 2023 · 1 comment
Open

Appraisal Specific Target Selection #75

Eein opened this issue Sep 12, 2023 · 1 comment
Assignees

Comments

@Eein
Copy link
Collaborator

Eein commented Sep 12, 2023

Currently when selecting targets in game, its hard to determine what player skills are doing because of AOE targeting noise.

We need to create a better player class that maps directly to memory, along with all skill definitions and other stats. This way, we know exactly WHAT skill is target WHAT enemy when doing battle commands.

Each command (attack or skill) has a way to get its current target that sticks around, but its quite deep and not required at most circumstances in battle; so it would be best left to track this only when a skill is attempting to target an enemy.

I've verified the case in which its an AOE ability, that targeting works as intended; however its unknown what character you are on, so i'm just taking the first characters in the items list for special move targeting, since characters have an enemy targeting mechanism as their first skill.

This is a bad, but best case scenario for now until a sizeable amount of work is done refactoring player memory.

includes #93 but for this class

@Eein Eein self-assigned this Sep 12, 2023
@Eein
Copy link
Collaborator Author

Eein commented Nov 10, 2023

noise has been consolidated by using mainTarget instead of currentTarget on target selector

We still need to delegate target selection to the current appraisal

@Eein Eein changed the title Extract a clearer Player from memory Appraisal Specific Target Selection Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant