Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build due to outdated bitvec #296

Closed
cfslpower opened this issue Nov 16, 2022 · 6 comments
Closed

Can't build due to outdated bitvec #296

cfslpower opened this issue Nov 16, 2022 · 6 comments

Comments

@cfslpower
Copy link

Latest version of Deku depends on bitvec = "0.22.1" which itself depends on funty = "1.2". This version of funty was yanked after ferrilab/funty#3 and Deku no longer builds. Later versions of bitvec depend on the later (not yanked) versions instead.

It seems like #281 already exists to fix this, but as of a few hours ago that PR is probably necessary to build Deku again.

@sharksforarms
Copy link
Owner

Hi, I've release a version of deku 0.15.0 which updates to the latest bitvec, however, there are some breaking changes/performance impacts. See #281 and https://github.com/sharksforarms/deku/blob/master/CHANGELOG.md#0150---2022-11-16

@vext01
Copy link
Contributor

vext01 commented Nov 24, 2022

I was using BitSlice::as_raw_slice(), which they've removed.

I was converting the remaining bytes returned by a deku read() back into a &[u8]. Seems this is no longer possible.

The bitvec docs says to use BitSlice::domain(), but I don't see how that helps.

@vext01
Copy link
Contributor

vext01 commented Nov 24, 2022

Well I fixed it by just not going back to &[u8] and working on a BitSlice instead. It's kind of annoying, as it forces me to work at bit-level granularity, but at the time I was using as_raw_slice(), I knew the BitSlice was a multiple of 8-bits in length.

Oh well.

@sharksforarms
Copy link
Owner

Can you use .domain().region().unwrap().1? This is what deku uses, see: https://github.com/sharksforarms/deku/pull/281/files

@vext01
Copy link
Contributor

vext01 commented Nov 24, 2022

Ah, that's how it's done :P

@hanusek
Copy link

hanusek commented Dec 22, 2022

I have a problem with deku 0.13.0. I need compatibility with rust 1.54.
Unfortunately, deku 15.0 an bitvec 1.0.0 have not.
https://lib.rs/compat/bitvec
https://lib.rs/compat/deku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants