-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download continues after maxContentLength exceeded #1098
Download continues after maxContentLength exceeded #1098
Comments
👍 Same problem here. I looked into the code of lib/adapters/http.js, and I made some tests. lib/adapters/http.js:173
This simple modification works in my tests, the rest of the reponse body is not fully loaded into memory anymore. Another way to obtain this behavior is to destroy the response stream in the catch handler in the client code:
This is an acceptable solution for me, don't know if you want to make this behavior the default ? (I think it would me more sensible). At least we could add this method in the documentation ? Thanks in advance. |
What's the likelihood of this PR getting approved / merged? Sourceclear is raising this as a vulnerability, with this PR being the fix: |
It is getting a high severity security hole now from GitHub, what is going on? |
Given the open issue axios/axios#1098, I decided to remove axios from the example project.
I'm pretty sure the maintainers are AWOL. |
Does this impact Axios in browser or just server? |
As mentioned on the Snyk blog If you are requesting resources from untrusted sources, or via insecure mediums, then you are potentially vulnerable to Denial of Service where malicious users can control the remote resource. When using axios in a Node.js server this can be disastrous due to the single threaded nature of the runtime. A spike in resources such as I/O and CPU negatively affect all users connected to that server. In browser environments, the Denial of Service negatively affects end-users with varying severity, depending on how the resource fetching with axios is used in the application. |
Fix is released as part of 0.19.0; per @emilyemorehouse's comment there should be a more targeted 0.18.1 release made available as well shortly. Let's all thank the maintainers and contributors for their generous work <3 |
* Add react-hooks-axios to Libraries section of ECOSYSTEM.md (axios#1925) * Update README.md. - Add Querystring library note (axios#1896) * Update README.md. Querystring libraries note * Typo in README.md Co-Authored-By: airs0urce <[email protected]> * Update README.md Co-Authored-By: airs0urce <[email protected]> * Add issue templates * Fixing Mocha tests by locking follow-redirects version to 1.5.10 (axios#1993) * docs(ECOSYSTEM): add axios-api-versioning (axios#2020) * Makes Axios error generic to use AxiosResponse (axios#1738) * Destroy stream on exceeding maxContentLength (fixes axios#1098) (axios#1485) * Clarify what values responseType can have in Node (axios#2121) It seems that `responseType: 'blob'` doesn't actually work in Node (when I tried using it, response.data was a string, not a Blob, since Node doesn't have Blobs), so this clarifies that this option should only be used in the browser * Update README.md. - Change `.then` to `.finally` in example code (axios#2090) * Fixing spacing for README.md (axios#2066) * Update README.md - Add instructions for installing with yarn (axios#2036) * Unzip response body only for statuses != 204 (axios#1129) * Add r2curl in ECOSYSTEM (axios#2141) * Update ECOSYSTEM.md - Add Axios Endpoints (axios#2176) * Add DELETE to list of methods that allow data as a config option (axios#2169) * Add information about auth parameter to README (axios#2166) * Update Changelog for release (0.19.0) * Releasing 0.19.0 * Fix typo in CHANGELOG.md - s/issue/issues (axios#2193) - issue link is not found. - typo: issue => issues * Fix travis CI build (axios#2386) * Do not modify config.url when using a relative baseURL (resolves axios#1628) (axios#2391) * Adding tests to show config.url mutation Because config.url is modified while processing the request when the baseURL is set, it is impossible to perform a retry with the provided config object. Ref axios#1628 * Fixing url combining without modifying config.url As config.url is not modified anymore during the request processing. The request can safely be retried after it failed with the provided config. resolves axios#1628 * Fix a typo in README (axios#2384) * Fix grammar in README.md (axios#2271) * Axios create url bug (axios#2290) * Fix axios#2234 * added spacing --eslint * added test cases * removed unexpected cases after updating the code * Fixing set `config.method` after mergeConfig for Axios.prototype.request (axios#2383) Inside Axios.prototype.request function, It's forced to set method to 'get' after `mergeConfig` if config.method exists, which makes the defaults.method not effective. * Fixing custom config options (axios#2207) - fixes axios#2203 * Doc fixes, minor examples cleanup (axios#2198) * README.md COOKBOOK.md: minor fixes * simplify language * ECOSYSTEM: create a few categories * Examples: log port listening to * upgrade bootstrap 3 -> 4 in examples bootstrap 4 is slightly smaller then 3.2.0 so it should also help load examples faster * categorize 0.19 items a little differently surface user/consumer changes first * Update response interceptor docs (axios#2399) * Fix cancellation error on build master. axios#2290 axios#2207 (axios#2407) * docs: minor tweak (axios#2404) made the license section link up to the respective file. * Sintaxe alternative to send data into the body (axios#2317) * upadating README: notes on CommonJS autocomplete (axios#2256) closes axios#2226. add note on how to gain typings / autocomplete / intellisense when using CommonJS (`require()`) imports * updating spelling and adding link to docs (axios#2212) * Fixing issue 2195 - order of if/else blocks is causing unit tests mocking XHR. (axios#2201) * 🐛Fix request finally documentation in README (axios#2189) * Fixing socket hang up error on node side for slow response. (axios#1752) * Fixing socket hang up error on node side for slow response. * eslint check * Fix word 'sintaxe' to 'syntax' in README.md (axios#2432) - translate 'sintaxe' word from portuguese to english * Add toJSON property to AxiosError type (axios#2427) I noticed the error object has a `toJSON` method but when I tried to use it in my typescript code it complained it didn't exist, even though I was using the `AxiosError` type. * Make redirection from HTTP to HTTPS work (axios#2426) When calling an HTTP resource redirecting to a HTTPS one with a keepAlive agent. We get the following error: ``` TypeError [ERR_INVALID_PROTOCOL]: Protocol "https:" not supported. Expected "http:" at new ClientRequest (_http_client.js:119:11) at Object.request (https.js:281:10) at RedirectableRequest._performRequest (/Users/jthomassey/projects/ecom-shop-web/node_modules/follow-redirects/index.js:169:24) at RedirectableRequest._processResponse (/Users/jthomassey/projects/ecom-shop-web/node_modules/follow-redirects/index.js:260:10) at ClientRequest.RedirectableRequest._onNativeResponse (/Users/jthomassey/projects/ecom-shop-web/node_modules/follow-redirects/index.js:50:10) at Object.onceWrapper (events.js:277:13) at ClientRequest.emit (events.js:189:13) at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:556:21) at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17) at Socket.socketOnData (_http_client.js:442:20) ``` This can be tested here : ``` const http = require('http'); const https = require('https'); const axios = require('axios'); axios.get('http://www.photobox.fr', { httpAgent: http.Agent({ keepAlive:true }), httpsAgent: https.Agent({ keepAlive:true }) }) .then(response => { console.log(response); console.log(response.headers); }) .catch(error => { console.log(error); }); ``` Axios delegate the redirection to the follow-redirect package which accept an option `agents` for both http and https agent see : https://github.com/follow-redirects/follow-redirects#per-request-options * fix: Fixing subdomain handling on no_proxy (axios#2442) * Add license badge (axios#2446) MIT License badge added in README.md file * Fixing Vulnerability A Fortify Scan finds a critical Cross-Site Scrip… (axios#2451) * Fixing Vulnerability A Fortify Scan finds a critical Cross-Site Scripting * use var insted of const * Add error toJSON example (axios#2466) * custom timeout prompt copy (axios#2275) * style: ui * feat: custom timeout txtx * feat: custom timeout txtx * Fixing missing words in docs template (axios#2259) * Fix to prevent XSS, throw an error when the URL contains a JS script (axios#2464) * Fixes issue where XSS scripts attacks were possible via the URL * Fix error * Move throwing error up * Add specs and make regex cover more xss cases * Update Webpack + deps, remove now unnecessary polyfills (axios#2410) * Update deps * handles webpack 1 -> 4 migration * remove promise helpers from dev files assume `Promise` is available, or polyfilled by the consumer * Remove isArray util. `isArray` has good coverage, even in IE9. So lets remove the custom polyfill. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray also resolves a few lint issues * Remove trim util String.protoype.trim has good coverage (including IE9) https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/Trim Also, the http adapter already uses the native method. * Change syntax to see if build passes (axios#2488) * Change syntax to see if build passes * Test commit * Test with node 10 * Test adding all browsers in travis * remove other browsers when running on travis * Revert "Update Webpack + deps, remove now unnecessary polyfills" (axios#2479) * Revert "Update Webpack + deps, remove now unnecessary polyfills (axios#2410)" This reverts commit 189b34c. * Fix build (axios#2496) * Change syntax to see if build passes * Test commit * Test with node 10 * Test adding all browsers in travis * remove other browsers when running on travis * Update README.md (axios#2504) * Adding Typescript HTTP method definition for LINK and UNLINK. (axios#2444) * Update docs with no_proxy change, issue axios#2484 (axios#2513) * Document fix (axios#2514) * Adding options typings (axios#2341) * Fix XSS logic that matched some valid urls (axios#2529) * Fix XSS logic that matched some valid urls, e.g. "/one/?foo=bar", when it shouldn't match those * Fix badge, use master branch (axios#2538) * Remove dependency on is-buffer (axios#1816) * Remove dependency on is-buffer from package.json * Fix CI build failure (axios#2570) * fixing Travis link (axios#2540) * Remove 'includes' API, fix CI build failure (axios#2574) * Remove 'includes' API, fix CI build failure * fix: fix ignore set withCredentials false (axios#2582) * Fixing invalid agent issue (axios#1904) * If this place is false, it will report an error, so you should delete the useless code. (axios#2458) * Fixing typo in CHANGELOG.md: s/Functionallity/Functionality (axios#2639) * Releasing 0.19.1 * Fix link formatting in CHANGELOG.md to display PR number in parens as link (axios#2643) * Remove unnecessary XSS check introduced by axios#2451 (axios#2679) * Remove unnecessary XSS check introduced by axios#2451 * Remove test file of `isValidXss` * Updating changlog for 0.19.2 release * Releasing 0.19.2 * Revert `finally` as `then` (axios#2683) Co-authored-by: Yasu Flores <[email protected]> * chore: add `jsdelivr` and `unpkg` support (axios#2443) * Fix merging of params (axios#2656) * Name function to avoid ESLint func-names warning * Switch params config to merge list and update tests * Restore testing of both false and null * Restore test cases for keys without defaults * Include test for non-object values that aren't false-y. * Compatible with follow-redirect aborts the request (axios#2689) * Compatible with follow-redirect aborts the request * Use the error code * Fix tests in browsers (axios#2748) * Fixing issue for HEAD method and gziped repsonse (axios#2666) * Fixing unit test failure in Windows OS (axios#2601) Co-authored-by: Xianming Zhong <[email protected]> * Adding jsDelivr link in README (axios#1110) * Adding jsDelivr link * Add SRI * Remove SRI Co-authored-by: Yasu Flores <[email protected]> Co-authored-by: Xianming Zhong <[email protected]> * Adding responseEncoding to mergeConfig (axios#1745) Co-authored-by: Xianming Zhong <[email protected]> * Update ' sign to ` in proxy spec (axios#2778) * Add `onUploadProgress` and `onDownloadProgress` are browser only (axios#2763) Saw in axios#928 and axios#1966 that `onUploadProgress` and `onDownloadProgress` only work in the browser and was missing that from the README. Co-authored-by: Xianming Zhong <[email protected]> * Added Response header access instructions (axios#1901) * Added Response header access instructions * Added note about using bracket notation * Include axios-hooks in ECOSYSTEM.md (axios#2003) * Fixing CHANGELOG.md issue link (axios#2784) * Add test for redirecting with too large response (axios#2695) * Add independent `maxBodyLength` option (axios#2781) * Add independent option to set the maximum size of the request body * Remove maxBodyLength check * Update README * Assert for error code and message * Adding option to disable automatic decompression (axios#2661) * Adding ability to disable auto decompression * Updating decompress documentation in README * Fixing test\unit\adapters\http.js lint errors * Adding test for disabling auto decompression * Removing changes that fixed lint errors in tests * Removing formating change to unit test Co-authored-by: Xianming Zhong <[email protected]> * Adding tests for method `options` type definitions (axios#1996) Update tests. Co-authored-by: Xianming Zhong <[email protected]> * Allow PURGE method in typings (axios#2191) Co-authored-by: Xianming Zhong <[email protected]> * Fixing getting local files (file://) failed (axios#2470) * fix issue axios#2416, axios#2396 * fix Eslint warn * Modify judgment conditions * add unit test * update unit test * update unit test * Fixing 'progressEvent' type (axios#2851) * Fix 'progressEvent' type * Update axios.ts * Updating documentation for usage form-data (axios#2805) Closes axios#2049 Co-authored-by: Xianming Zhong <[email protected]> * Update README.md about validateStatus (axios#2912) Rewrote the comment from "Reject only if the status code is greater than or equal to 500" to "Resolve only if the status code is less than 500" * Documentation update to clear up ambiguity in code examples (axios#2928) * Made a adjustment to the documenation to clear up any ambiguity around the use of "fs". This should help clear up that the code examples with "fs" cannot be used on the client side. Co-authored-by: Jay <[email protected]> * Add CDNJS version badge in README.md (axios#878) This badge will show the version on CDNJS! Co-authored-by: Jay <[email protected]> * Fixing Cookie Helper with Asyc Components (axios#1105) (axios#1107) Co-authored-by: Jay <[email protected]> * Bug/allow header to contain http verb keys axios#1252 (axios#1258) * Failing test for axios#1252 * Only delete header keys that match an HTTP verb if the value is a non-string Co-authored-by: David Ko <[email protected]> Co-authored-by: Jay <[email protected]> * Revert "Bug/allow header to contain http verb keys axios#1252 (axios#1258)" (axios#2977) This reverts commit 920510b. * fix 'Network Error' in react native android (axios#1487) There is a bug in react native Android platform when using get method. It will trigger a 'Network Error' when passing the requestData which is an empty string to request.send function. So if the requestData is an empty string we can set it to null as well to fix the bug. Co-authored-by: Jay <[email protected]> * Fixing password encoding with special characters in basic authentication (axios#1492) * Fixing password encoding with special characters in basic authentication * Adding test to check if password with non-Latin1 characters pass Co-authored-by: petr.mares <[email protected]> Co-authored-by: Jay <[email protected]> * Fixing special char encoding (axios#1671) * removing @ character from replacement list since it is a reserved character * Updating buildURL test to not include the @ character * Removing console logs Co-authored-by: Jay <[email protected]> * Fixing default transformRequest with buffer pools (axios#1511) * Fixing default transformRequest of TypedArrays with buffer pools A buffer pool is a large ArrayBuffer of a preset size used with a TypedArray such as Uint8Array. This can speed up performance when constructing TypedArrays of unknown sizes, and is a technique used by Node with their Buffers, and by libraries like dcodeIO/protobuf.js. Because the ArrayBuffer of such a TypedArray is much longer than the array itself, using `.buffer` to transform the array before POSTing results in sending a request with many extraneous empty bytes, which is wastefule and may result in unexpected behavior. Using `.slice()` before grabbing the ArrayBuffer fixes the problem by creating a new TypedArray with a buffer of the expected length. Signed-off-by: Zac Delventhal <[email protected]> * Adding test for using default transformRequest with buffer pools Adds a new test to the default transformRequest, running it on a Uint8Array with a byte length of 16, but a much larger ArrayBuffer with a byte length of 256. The transformed array should not include any extra bytes, and so must have a byte length of just 16. Signed-off-by: Zac Delventhal <[email protected]> Co-authored-by: Zac Delventhal <[email protected]> Co-authored-by: Jay <[email protected]> * Include swagger-taxos-codegen in ECOSYSTEM.md (axios#2162) Co-authored-by: Jay <[email protected]> * Fixing an issue that type 'null' is not assignable to validateStatus (axios#2773) Co-authored-by: Xianming Zhong <[email protected]> Co-authored-by: Jay <[email protected]> * Update README.md (axios#2887) Small change to the data attribute doc of the config. A request body can also be set for DELETE methods but this wasn't mentioned in the documentation (it only mentioned POST, PUT and PATCH). Took my some 10-20 minutes until I realized that I don't need to manipulate the request body with transformRequest in the case of DELETE. Co-authored-by: Jay <[email protected]> * Remove axios.all() and axios.spread() from Readme.md (axios#2727) * Updating Readme.md - remove axios.all(), axios.spread() * Updating Readme.md - replace example - axios.all() -> Promise.all() - axios.spread(function (acct, perms)) -> function (acct, perms) - add deprecated mark * Update README.md Make changes after review Co-authored-by: Jay <[email protected]> * Revert "Fixing default transformRequest with buffer pools (axios#1511)" (axios#2982) This reverts commit a9a3b5e. * Fixing overwrite Blob/File type as Content-Type in browser. (axios#1773) Co-authored-by: Jay <[email protected]> * Allow opening examples in Gitpod (axios#1958) Co-authored-by: Emily Morehouse <[email protected]> Co-authored-by: Jay <[email protected]> * Include axios-data-unpacker in ECOSYSTEM.md (axios#2080) Co-authored-by: Jay <[email protected]> * docs(): Detailed config options environment. (axios#2088) * docs(): Detailed config options environment. * Update README.md Co-authored-by: Jay <[email protected]> * Adding console log on sandbox server startup (axios#2210) * Adding console log on sandbox server startup * Update server.js Add server error handeling * Update server.js Better error message, remove retry. Co-authored-by: Philippe Recto <[email protected]> Co-authored-by: Felipe Martins <[email protected]> Co-authored-by: Jay <[email protected]> * Add test with Node.js 12 (axios#2860) * test with Node.js 12 * test with latest Co-authored-by: Jay <[email protected]> * Allow unsetting headers by passing null (axios#382) (axios#1845) Co-authored-by: Jay <[email protected]> * Refactor mergeConfig without utils.deepMerge (axios#2844) * Adding failing test * Fixing axios#2587 default custom config persisting * Adding Concat keys and filter duplicates * Fixed value from CPE * update for review feedbacks * no deepMerge * only merge between plain objects * fix rename * always merge config by mergeConfig * extract function mergeDeepProperties * refactor mergeConfig with all keys, and add special logic for validateStatus * add test for resetting headers * add lots of tests and fix a bug * should not inherit `data` * use simple toString * revert axios#1845 Co-authored-by: David Tanner <[email protected]> Co-authored-by: Justin Beckwith <[email protected]> * Replace 'blacklist' with 'blocklist' (axios#3006) * Add GitHub actions to close invalid issues (axios#3022) * add close actions * fix with checkout * update issue templates * add reminder * update close message * Add GitHub actions to close stale issues/prs (axios#3029) * prepare stale actions * update messages * Add exempt labels and lighten up comments Co-authored-by: Jay <[email protected]> * Update close-issues.yml (axios#3031) * Update close-issues.yml Update close message to read better 😄 * Fix use of quotations Use single quotes as per other .yml files * Remove user name form message * Add days and change name to work (axios#3035) * Fix stale bot config (axios#3049) * fix stale bot config * fix multiple lines * add table of content (preview) (axios#3050) * add toc (preview) * remove toc in toc Signed-off-by: Moni <[email protected]> * fix sublinks * fix indentation * remove redundant table links * update caps and indent * remove axios Co-authored-by: Moni <[email protected]> Co-authored-by: Jay <[email protected]> * Adding support for URLSearchParams in node (axios#1900) * Adding support for URLSearchParams in node * Remove un-needed code * Update utils.js * Make changes as suggested Co-authored-by: Kamil Posiadala <[email protected]> Co-authored-by: Jay <[email protected]> Co-authored-by: Cody Chan <[email protected]> Co-authored-by: Dmitriy Eroshenko <[email protected]> Co-authored-by: Emily Morehouse <[email protected]> Co-authored-by: grumblerchester <[email protected]> Co-authored-by: Weffe <[email protected]> Co-authored-by: Suman Lama <[email protected]> Co-authored-by: Gadzhi Gadzhiev <[email protected]> Co-authored-by: Tyler Breisacher <[email protected]> Co-authored-by: Omar Cai <[email protected]> Co-authored-by: Josh McCarty <[email protected]> Co-authored-by: Victor Hermes <[email protected]> Co-authored-by: drawski <[email protected]> Co-authored-by: 유용우 / CX <[email protected]> Co-authored-by: Renan <[email protected]> Co-authored-by: Daniela Borges Matos de Carvalho <[email protected]> Co-authored-by: xlaguna <[email protected]> Co-authored-by: Takahiro Ikeda <[email protected]> Co-authored-by: Felipe Martins <[email protected]> Co-authored-by: multicolaure <[email protected]> Co-authored-by: Denis Sikuler <[email protected]> Co-authored-by: Michael Foss <[email protected]> Co-authored-by: DIO <[email protected]> Co-authored-by: bushuai <[email protected]> Co-authored-by: Rafael Renan Pacheco <[email protected]> Co-authored-by: Avindra Goolcharan <[email protected]> Co-authored-by: Sagar Acharya <[email protected]> Co-authored-by: James George <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: Vamp <[email protected]> Co-authored-by: Fabio Aiello <[email protected]> Co-authored-by: Joshua Melvin <[email protected]> Co-authored-by: Ahmed Tarek <[email protected]> Co-authored-by: Ya Hui Liang(Ryou) <[email protected]> Co-authored-by: Jihwan Oh <[email protected]> Co-authored-by: Tiago Rodrigues <[email protected]> Co-authored-by: Jeremie Thomassey <[email protected]> Co-authored-by: Maskedman99 <[email protected]> Co-authored-by: Wataru <[email protected]> Co-authored-by: Yasu Flores <[email protected]> Co-authored-by: IVLIU <[email protected]> Co-authored-by: Crhistian Ramirez <[email protected]> Co-authored-by: Harshit Singh <[email protected]> Co-authored-by: Marlon Barcarol <[email protected]> Co-authored-by: Luke Policinski <[email protected]> Co-authored-by: Angelos Chalaris <[email protected]> Co-authored-by: Alanscut <[email protected]> Co-authored-by: ZhaoXC <[email protected]> Co-authored-by: Michael Shin <[email protected]> Co-authored-by: 不才 <[email protected]> Co-authored-by: Malik Dirim <[email protected]> Co-authored-by: Emily Morehouse <[email protected]> Co-authored-by: Xianming Zhong <[email protected]> Co-authored-by: JounQin <[email protected]> Co-authored-by: Jonathan Sharpe <[email protected]> Co-authored-by: Nikita Galkin <[email protected]> Co-authored-by: jennynju <[email protected]> Co-authored-by: Lukas Drgon <[email protected]> Co-authored-by: Thibault Ehrhart <[email protected]> Co-authored-by: Jimmy Liao <[email protected]> Co-authored-by: Ian Wijma <[email protected]> Co-authored-by: Alexandru Ungureanu <[email protected]> Co-authored-by: Simone Busoli <[email protected]> Co-authored-by: Fonger <[email protected]> Co-authored-by: Gustavo López <[email protected]> Co-authored-by: Spencer von der Ohe <[email protected]> Co-authored-by: Motonori Iwata <[email protected]> Co-authored-by: Alan Wang <[email protected]> Co-authored-by: Benny Neugebauer <[email protected]> Co-authored-by: Remco Haszing <[email protected]> Co-authored-by: hexaez <[email protected]> Co-authored-by: Jay <[email protected]> Co-authored-by: Jay <[email protected]> Co-authored-by: Samina Fu <[email protected]> Co-authored-by: Ryan Bown <[email protected]> Co-authored-by: David Ko <[email protected]> Co-authored-by: David Ko <[email protected]> Co-authored-by: huangzuizui <[email protected]> Co-authored-by: Petr Mares <[email protected]> Co-authored-by: petr.mares <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Zac Delventhal <[email protected]> Co-authored-by: Zac Delventhal <[email protected]> Co-authored-by: Michał Zarach <[email protected]> Co-authored-by: Taemin Shin <[email protected]> Co-authored-by: marcinx <[email protected]> Co-authored-by: Taegyeoung Oh <[email protected]> Co-authored-by: George Cheng <[email protected]> Co-authored-by: Sven Efftinge <[email protected]> Co-authored-by: Anubhav Srivastava <[email protected]> Co-authored-by: jeffjing <[email protected]> Co-authored-by: Philippe Recto <[email protected]> Co-authored-by: Philippe Recto <[email protected]> Co-authored-by: Martti Laine <[email protected]> Co-authored-by: David Tanner <[email protected]> Co-authored-by: Justin Beckwith <[email protected]> Co-authored-by: rockcs1992 <[email protected]> Co-authored-by: Frostack <[email protected]> Co-authored-by: Moni <[email protected]> Co-authored-by: Kamil Posiadała <[email protected]> Co-authored-by: Kamil Posiadala <[email protected]>
#### Summary
The following code demonstrates the issue:
Expected behavior:
Actual behavior:
It's possible to work around this by adding a cancellation token and manually canceling the request when an error is encountered. However, since the request never actually fires a "complete" event, it's surprising that the download continues, only to have the data be thrown into the void.
#### Context
The text was updated successfully, but these errors were encountered: