Skip to content

Scrolling with Magic Trackpad on MBP is not supported #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vt128 opened this issue Nov 20, 2020 · 7 comments
Closed

Scrolling with Magic Trackpad on MBP is not supported #1387

vt128 opened this issue Nov 20, 2020 · 7 comments
Labels
packaging/tooling upstream-error A bug in an upstream component

Comments

@vt128
Copy link

vt128 commented Nov 20, 2020

What version of bat are you using?
[paste the output of bat --version here]

bat 0.16.0

Describe the bug you encountered:

Scrolling with Magic Trackpad on MBP is not supported.

What did you expect to happen instead?

Can scroll like using less

How did you install bat?

Homebrew


[paste the output of info.sh here]

@vt128 vt128 added the bug Something isn't working label Nov 20, 2020
@eth-p
Copy link
Collaborator

eth-p commented Nov 20, 2020

What version of less are you using?

If you're using an old version, bat automatically passes --no-init to less in order to avoid a bug. Unfortunately, that also has the effect of disabling scroll wheel support.

If it's less than version 530, a brew install less should fix the issue.

@vt128
Copy link
Author

vt128 commented Nov 21, 2020

On macOS:

less 487 (POSIX regular expressions)
Copyright (C) 1984-2016  Mark Nudelman

less comes with NO WARRANTY, to the extent permitted by law.
For information about the terms of redistribution,
see the file named README in the less distribution.
Homepage: http://www.greenwoodsoftware.com/less

On Ubuntu 18.04 with the same issue:

❯ less --version
less 487 (GNU regular expressions)
Copyright (C) 1984-2016  Mark Nudelman

less comes with NO WARRANTY, to the extent permitted by law.
For information about the terms of redistribution,
see the file named README in the less distribution.
Homepage: http://www.greenwoodsoftware.com/less

@eth-p
Copy link
Collaborator

eth-p commented Nov 21, 2020

Yeah, your version of less is outdated. I'm not sure how to get the latest for Ubuntu, but on your Mac the issue should be fixed if you install less through homebrew.

@vt128
Copy link
Author

vt128 commented Nov 21, 2020

Well, the dep on less seems a little bit strange.

I'm not familiar with Rust, but have you ever think about rewrite this very dep, or compile latest less with Rust code of bat (some tech like JIT, or cgo in Golang)?

@sharkdp
Copy link
Owner

sharkdp commented Nov 23, 2020

Well, the dep on less seems a little bit strange.

Why? bat uses less as an external pager. If you talk about versioning, yes. Package maintainers should probably make sure that we have a compatible version of less installed. We would need to figure out what that version is. It depends on the OS. For Linux/macOS, I would guess that 551 is fine. For Windows, a very recent version is needed to avoid a few bugs.

@sharkdp sharkdp added packaging/tooling upstream-error A bug in an upstream component and removed bug Something isn't working labels Nov 23, 2020
@sharkdp
Copy link
Owner

sharkdp commented Nov 23, 2020

I'm not familiar with Rust, but have you ever think about rewrite this very dep,

yes, see #1053

or compile latest less with Rust code of bat (some tech like JIT, or cgo in Golang)?

I have not thought about that, but I don't really want to get into this. We support a large number of operating systems and CPU architectures. I think this is better left to OS package maintainers.

@sharkdp
Copy link
Owner

sharkdp commented Dec 29, 2020

I'm closing this for now, but maybe we should consider adding "less" as a dependency for the "bat" homebrew package?

@sharkdp sharkdp closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging/tooling upstream-error A bug in an upstream component
Projects
None yet
Development

No branches or pull requests

3 participants