Changes to ListingPage #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OtterleyW
commented
Nov 18, 2019
•
OtterleyW
commented
Gnito
reviewed
Nov 18, 2019
| options={options} | ||
| options={options.filter(o => { | ||
| return selectedOptions.find(s => s === o.key); | ||
| })} | ||
| selectedOptions={selectedOptions} | ||
| twoColumns={true} |
There was a problem hiding this comment.
If you create variable out of filter
(e.g. const selectedConfigOptions = options.filter(o => selectedOptions.find(s => s === o.key));
you could add here something like:
twoColumns={selectedConfigOptions > 5}
Gnito
reviewed
Nov 18, 2019
OtterleyW
force-pushed
the
edit-listing-page
branch
4 times, most recently
from
f0fb695
to
6dfedca
Compare
OtterleyW
force-pushed
the
edit-listing-page
branch
from
3df4684
to
7cd3ce8
Compare
Merged
ghost
pushed a commit
to Skillpickr/forked-sharetribe
that referenced
this pull request
Feb 13, 2023
Feature/list view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.