Update sentry #999
Merged
Update sentry #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
update-sentry
branch
2 times, most recently
from
e94de81
to
1633966
Compare
Gnito
reviewed
Jan 16, 2019
src/util/log.js
Outdated
| Sentry.captureException(e); | ||
| }); | ||
|
|
||
| //Sentry.captureException(e, { tags: { code }, extra }); |
Gnito
reviewed
Jan 16, 2019
| return scope.setTag(tag, extra[tag]); | ||
| }); | ||
| Sentry.captureException(e); | ||
| }); |
There was a problem hiding this comment.
I think this should use setExtra instead of just setTag:
const extra = { ...data, apiErrorData: responseApiErrorInfo(e) };
Sentry.withScope(scope => {
scope.setTag('code', code);
Object.keys(extra).forEach(key => {
scope.setExtra(key, extra[key]);
});
Sentry.captureException(e);
});There was a problem hiding this comment.
Change this part also in server/log.js!
OtterleyW
force-pushed
the
update-sentry
branch
from
1633966
to
c43f9c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Sentry SDKs for browser and Node.js to version 4.5.1. With the new SDKs only one
DSN needs to be configured so update also environment variables and documentation related to
Sentry.