Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSP is dead and the API no longer resolves - replace with yarn audit.… #978

Closed
wants to merge 1 commit into from

Conversation

rdoh
Copy link
Contributor

@rdoh rdoh commented Dec 17, 2018

@Gnito
Copy link
Contributor

Gnito commented Dec 17, 2018

@rdoh thanks for the pull request, we were out of reach last week and haven't had time to fix this. We appreciate that there're pull requests or issues created out of deploy problems to alert others who have dependencies to this codebase.

That being said, we'll make another PR to handle the required changes a bit faster this time.


I actually think we should drop the CI task altogether - until we have something better figured out.

The problem is that there are lots of dependencies that come from Create React App 1.x.x version (like Prototype pollution with paths pointing to CRA fork: sharetribe-scripts > jest > jest-cli > jest-runtime > jest-haste-map > sane > exec-sh > merge), and we have exceptions for those in .nsprc file.

So, in addition to changes mentioned in this PR, I'd propose that we:

  1. Drop CI
  2. Remove dev dependencies:
    "nsp": "^3.2.1",
    "nsp-preprocessor-yarn": "^1.0.1",

TODO:
Now: remove circleci task
Future task: add audit script that checks against saved snapshot or exception list.

(Although, running yarn audit --json gives data worth of 10 MB - so, snapshot is probably not a good idea.)

@OtterleyW
Copy link
Contributor

Closing this PR because #979 is now merged.

@OtterleyW OtterleyW closed this Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants