Manage Availability #972
Merged
Manage Availability #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
manage-availability
branch
from
89dae8a
to
63bfc65
Compare
Gnito
force-pushed
the
manage-availability
branch
2 times, most recently
from
1d59236
to
6ca70ae
Compare
Gnito
force-pushed
the
manage-availability
branch
from
6ca70ae
to
27db13c
Compare
Gnito
force-pushed
the
manage-availability
branch
3 times, most recently
from
a023d0e
to
ecd93bf
Compare
OtterleyW
approved these changes
Jan 4, 2019
| .title { | ||
| margin-bottom: 19px; | ||
|
|
||
| @media (--viewportLarge) { |
There was a problem hiding this comment.
Since this is a new CSS file would it be better not to nest the media queries? If it was something that we shouldn't do anymore.
|
|
||
| padding-top: 1px; | ||
|
|
||
| @media (--viewportMedium) { |
There was a problem hiding this comment.
Here the same thing with media queries. Would it be better not to nest them?
| ).seats; | ||
|
|
||
| const currentException = findException(exceptions, date); | ||
| const draft = draftException(exceptions, start, end, seatsFromPlan); |
There was a problem hiding this comment.
Could the variable draft be renamed to draftException and function draftExceptione.g. to makeDraftException for consistency because just draft might be confusing. At least I first thought it had something to do with a draft listing.
| @@ -33,18 +25,34 @@ | |||
| flex-grow: 1; | |||
| position: relative; | |||
| width: 100%; | |||
| height: 100%; | |||
| /*height: 100%;*/ | |||
Gnito
force-pushed
the
manage-availability
branch
from
ecd93bf
to
f82b569
Compare
- requestFetchBookings - requestFetchAvailabilityExceptions - requestCreateAvailabilityException - requestDeleteAvailabilityException
Gnito
force-pushed
the
manage-availability
branch
from
f82b569
to
afaee40
Compare
Gnito
force-pushed
the
manage-availability
branch
from
afaee40
to
3197d74
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Availability calendar for managing day and night availability through EditListingWizard.
EditListingPage / EditListingWizard will have a new panel: EditListingAvailabilityPanel.
In addition, ManageListingCard has link to that view in "your listings" page.
Note: French translations are not yet updated: changes to fr.json
Mobile (png):
Desktop (png):
