Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change supported node version to the latest LTS #964

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Change supported node version to the latest LTS #964

merged 2 commits into from
Dec 4, 2018

Conversation

lyyder
Copy link
Contributor

@lyyder lyyder commented Nov 28, 2018

No description provided.

@lyyder lyyder force-pushed the update-node branch 2 times, most recently from 602d0c7 to 81ee048 Compare November 29, 2018 08:35
Gnito
Gnito approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@Gnito Gnito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd recommend testing this with
a) yarn run dev-server and
b) building to staging before merging
(if you haven't already).

@lyyder lyyder temporarily deployed to sharetribe-starter-app December 4, 2018 08:09 Inactive
@lyyder lyyder temporarily deployed to sharetribe-starter-app December 4, 2018 11:12 Inactive
@lyyder lyyder merged commit a67d5f2 into master Dec 4, 2018
@lyyder lyyder deleted the update-node branch December 4, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnito Gnito Gnito approved these changes

@OtterleyW OtterleyW Awaiting requested review from OtterleyW

Assignees
No one assigned
Labels
review ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyyder @Gnito