Update JS SDK to 1.2 #963
Merged
Update JS SDK to 1.2 #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyyder
commented
Nov 28, 2018
| | REACT_APP_GOOGLE_ANALYTICS_ID | See: [Google Analytics](./analytics.md) | | ||
| | REACT_APP_AVAILABILITY_ENABLED | Enables availability calendar for listings. | | ||
| | REACT_APP_DEFAULT_SEARCHES_ENABLED | Enables default search suggestions in location autocomplete search input. | | ||
| | REACT_APP_SHARETRIBE_SDK_BASE_URL | The base url to access the Sharetribe Flex Marketplace API. FTW uses the correct one by default so no need to set this. | |
There was a problem hiding this comment.
Should this line be removed from here altogether? It just confuses FTW users and can be communicated in some other manner to FTW developers.
There was a problem hiding this comment.
IRL: lets keep for now
lyyder
commented
Nov 28, 2018
| @@ -32,6 +31,7 @@ REACT_APP_ENV=production | |||
| # BASIC_AUTH_USERNAME=sharetribe | |||
| # BASIC_AUTH_PASSWORD=secret | |||
| # REACT_APP_GOOGLE_ANALYTICS_ID=change-me | |||
| # REACT_APP_SHARETRIBE_SDK_BASE_URL=change-me | |||
There was a problem hiding this comment.
Maybe this could be removed also from the .env template.
There was a problem hiding this comment.
IRL: lets keep for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the SDK dependency to 1.2. The new version uses the Flex prod API base URL by default so remove the need of setting it in the template.