Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve production setup #961

Merged
merged 5 commits into from
Dec 3, 2018
Merged

Improve production setup #961

merged 5 commits into from
Dec 3, 2018

Conversation

OtterleyW
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved

![Heroku settings](./assets/deploying-to-production/heroku-config-vars.png)

#### Domains and certificates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sktoiva Do you have anything else that should be written about domain & SSL certs?
(And read the whole doc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say that:

"Heroku manages SSL certificates automatically for new applications. You can change your...."

* [Domains and certificates](#domains-and-certificates)
* [Heroku logs](#heroku-logs)

Before creating the app you need three accounts: [Heroku](https://heroku.com/), [Stripe](https://stripe.com/fi) and [MapBox](https://www.mapbox.com/). Creating the accounts is free unless you start heavily using them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now a duplicate from the beginning of the document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional because if there will be a link directly to "Deploying to Heroku" section reader might miss the first mention about this.

Copy link
Contributor

@lyyder lyyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, added a few (minor) comments.


### Creating a new app

The easiest way is to click the _"Deploy to Heroku"_ button (check the root folder in your forked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quotation marks and italics combined in a few places in the guide. Should we use one or the other?

dashboard using GitHub branches.

1. In Heroku dashboard go to _Deploy tab_ and find _Deployment method_ section.
2. Click _Connect to GitHub_ button. After that, you will see _Connect to GitHub_ section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to an extra whitespace after Click

README.md Outdated
**Note:** Remember to fork the repository before deploying the application. Connecting your own
Github repository to Heroku will make manual deploys easier.

See the [Deploying to Heroku](./docs/deploying-to-production.md#deploying-to-Heroku) for more
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe drop the "the", so

See [Deploying to Heroku]
or
See the [documentation about deploying to Heroku]

Small thing, I know.

@OtterleyW OtterleyW merged commit 54154a4 into master Dec 3, 2018
@OtterleyW OtterleyW deleted the improve-production-setup branch December 3, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants