-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve production setup #961
Conversation
9f2d94f
to
906b1d8
Compare
906b1d8
to
6f018e5
Compare
b519d3d
to
5edb4ad
Compare
5edb4ad
to
f9dcce7
Compare
|
||
![Heroku settings](./assets/deploying-to-production/heroku-config-vars.png) | ||
|
||
#### Domains and certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sktoiva Do you have anything else that should be written about domain & SSL certs?
(And read the whole doc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe say that:
"Heroku manages SSL certificates automatically for new applications. You can change your...."
docs/deploying-to-production.md
Outdated
* [Domains and certificates](#domains-and-certificates) | ||
* [Heroku logs](#heroku-logs) | ||
|
||
Before creating the app you need three accounts: [Heroku](https://heroku.com/), [Stripe](https://stripe.com/fi) and [MapBox](https://www.mapbox.com/). Creating the accounts is free unless you start heavily using them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now a duplicate from the beginning of the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional because if there will be a link directly to "Deploying to Heroku" section reader might miss the first mention about this.
f9dcce7
to
97b59c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, added a few (minor) comments.
|
||
### Creating a new app | ||
|
||
The easiest way is to click the _"Deploy to Heroku"_ button (check the root folder in your forked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's quotation marks and italics combined in a few places in the guide. Should we use one or the other?
docs/deploying-to-production.md
Outdated
dashboard using GitHub branches. | ||
|
||
1. In Heroku dashboard go to _Deploy tab_ and find _Deployment method_ section. | ||
2. Click _Connect to GitHub_ button. After that, you will see _Connect to GitHub_ section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to an extra whitespace after Click
README.md
Outdated
**Note:** Remember to fork the repository before deploying the application. Connecting your own | ||
Github repository to Heroku will make manual deploys easier. | ||
|
||
See the [Deploying to Heroku](./docs/deploying-to-production.md#deploying-to-Heroku) for more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd maybe drop the "the", so
See [Deploying to Heroku]
or
See the [documentation about deploying to Heroku]
Small thing, I know.
0167e28
to
c2b364a
Compare
c2b364a
to
284745f
Compare
8d7d0c3
to
62fbf08
Compare
No description provided.