Show Stripe error message if error contains Stripe error #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
fix-initial-order-error-bug
branch
from
83c09b7
to
84c2eee
Compare
Gnito
reviewed
Nov 22, 2018
src/util/errors.js
Outdated
| return errorAPIErrors(error).reduce((messages, apiError) => { | ||
| const isPaymentFailedError = | ||
| apiError.status === 402 && apiError.code === ERROR_CODE_PAYMENT_FAILED; | ||
| let hasMessage = apiError && apiError.meta && apiError.meta.stripeMessage; |
There was a problem hiding this comment.
No need to use let since there's no need to update the variable inside its lifespan (i.e. this function block).
Gnito
reviewed
Nov 22, 2018
src/util/errors.js
Outdated
| apiError.status === 402 && apiError.code === ERROR_CODE_PAYMENT_FAILED; | ||
| let hasMessage = apiError && apiError.meta && apiError.meta.stripeMessage; | ||
|
|
||
| return isPaymentFailedError && hasMessage ? [...messages, hasMessage] : messages; |
There was a problem hiding this comment.
This could be written as:
const hasStripeError = apiError && apiError.meta && apiError.meta.stripeMessage;
const stripeMessageMaybe = isPaymentFailedError && hasStripeError
? [apiError.meta.stripeMessage]
: [];
return [...messages, ...stripeMessageMaybe];(And probably isPaymentFailedError is redundant check.)
Gnito
reviewed
Nov 22, 2018
src/util/errors.js
Outdated
| * Check if the given API error (from `sdk.transaction.initiate()`) is | ||
| * due to other error in Stripe. | ||
| */ | ||
| export const isTransactionInitiateStripeError = error => { |
There was a problem hiding this comment.
Since this is not returning any boolean, the name should be something else.
How about transactionInitiateOrderStripeErrors or transactionInitiateStripeErrors?
OtterleyW
force-pushed
the
fix-initial-order-error-bug
branch
3 times, most recently
from
a2fea58
to
9892e2f
Compare
OtterleyW
force-pushed
the
fix-initial-order-error-bug
branch
from
9892e2f
to
979eaf2
Compare
Gnito
reviewed
Nov 26, 2018
| @@ -15,7 +15,9 @@ import { | |||
| isTransactionInitiateAmountTooLowError, | |||
| isTransactionInitiateListingNotFoundError, | |||
| isTransactionInitiateMissingStripeAccountError, | |||
| transactionInitiateOrderStripeErrors, | |||
There was a problem hiding this comment.
This could be moved to the end of this list. (This just looks funny in the middle of isTransaction... helper functions.
OtterleyW
force-pushed
the
fix-initial-order-error-bug
branch
from
979eaf2
to
24eeb90
Compare
Gnito
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.