Review translations configuration and documentation #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lyyder
commented
Nov 13, 2018
•
lyyder
commented
- remove unnecessary language configurations
- update translations documentation
lyyder
force-pushed
the
translations-configuration
branch
2 times, most recently
from
9b7e692
to
0e5d893
Compare
Gnito
reviewed
Nov 14, 2018
docs/translations.md
Outdated
| * In [src/app.js](../src/app.js), change the translation imports to point to the correct | ||
| `react-intl` locale and the new translations file you created, for example: | ||
|
|
||
| ``` |
Gnito
reviewed
Nov 14, 2018
docs/translations.md
Outdated
|
|
||
| 1. In [src/app.js](../src/app.js), change the translation imports to point to the correct | ||
| `react-intl` locale and the new translations file you created. | ||
| ``` |
Gnito
reviewed
Nov 14, 2018
docs/translations.md
Outdated
| in tests. To change the translation file used in tests change the `messages` variable in | ||
| [src/util/test-helpers.js](../src/util/test-helpers.js) to match your language in use, for example: | ||
|
|
||
| ``` |
Gnito
reviewed
Nov 14, 2018
| @@ -234,6 +234,7 @@ export class SearchPageComponent extends Component { | |||
| onCloseAsModal={() => { | |||
| onManageDisableScrolling('SearchPage.map', false); | |||
| }} | |||
| messages={intl.messages} | |||
Gnito
approved these changes
Nov 14, 2018
Translations are passed as props so the handling for translations in tests is already done in test-helpers.js.
lyyder
force-pushed
the
translations-configuration
branch
from
26a5b06
to
501d5b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.