Date filter #949
Merged
Date filter #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
date-filter
branch
5 times, most recently
from
23edb2e
to
2823fe8
Compare
OtterleyW
force-pushed
the
date-filter
branch
from
2823fe8
to
67b512d
Compare
OtterleyW
force-pushed
the
date-filter
branch
from
67b512d
to
adfa849
Compare
OtterleyW
force-pushed
the
date-filter
branch
2 times, most recently
from
6c5be04
to
7213299
Compare
Gnito
reviewed
Nov 20, 2018
| weekDayFormat: 'dd', | ||
| phrases: { | ||
| closeDatePicker: null, // Handled inside component | ||
| clearDate: null, // Handled inside component |
There was a problem hiding this comment.
Maybe these phrases could be left out.
phrases: {}, // Add overwrites to default phrases used by react-dates
|
Reorder commits so that "Add help functions for ISO8601 date format" is included before "Add DateRangeFilter to desktop and mobile versions". (i.e. functions are included before they are used) |
OtterleyW
force-pushed
the
date-filter
branch
from
7213299
to
d6331cb
Compare
lyyder
reviewed
Nov 22, 2018
| @@ -140,3 +140,11 @@ export const formatDate = (intl, todayString, d) => { | |||
|
|
|||
| return `${formattedDate}, ${formattedTime}`; | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
A comment for these ISO8601 functions would be nice. Like the ones on other helper functions in this file.
OtterleyW
force-pushed
the
date-filter
branch
from
d6331cb
to
fda3f20
Compare
OtterleyW
force-pushed
the
date-filter
branch
4 times, most recently
from
e907969
to
ac7346d
Compare
OtterleyW
force-pushed
the
date-filter
branch
2 times, most recently
from
4bb186a
to
5b37885
Compare
OtterleyW
force-pushed
the
date-filter
branch
from
41f2a09
to
a62b900
Compare
…ain and SelectSingleFilterPopup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
This PR adds date filter and refactors other filters to be more consistent: there are now plain and popup versions of select-single and select-multiple filters too.
BookingDateRangeFilter on mobile version
BookingDateRangeFilter on desktop version