Fix Firefox: color for select options #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
fix-ff-category-option
branch
from
ab5da7e
to
7627a9f
Compare
Gnito
force-pushed
the
fix-ff-category-option
branch
from
7627a9f
to
3c99a88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox has started passing color from
<select>to<option>elements. We had grey<select>to show placeholder text in grey. This fixes the situation so that<select>still has grey color, but its child<option>elements have separate color set.NOTE: placeholder option needs to be disabled for it to get disabled look (color will be grey and it's not selectable).