Referrer policy updates #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpuputti
approved these changes
Oct 16, 2018
bladealslayer
approved these changes
Oct 17, 2018
Gnito
force-pushed
the
referrer-policy-updates
branch
from
eb24a31
to
2456f24
Compare
|
FTW renders Helmet meta tags before we load anything external on public/index.html: <html data-htmlattr="htmlAttributes">
<head>
<meta charset="utf-8">
<!--!title-->
<meta name="viewport" content="width=device-width, initial-scale=1">
<!--!meta-->I updated this PR so that referrer is actually handled in Page.js, where it can be set as the first meta tag (in Helmet handled meta tags) Furthermore, I had to modify also canonical URL creation so that it doesn't contain query & fragment sections when referrer is enforced. (Including params is necessary for SearchPage and other situations where URL params affect to the content of the page.) This setup returns origin for the first external URL on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is to ensure that page with URLs that contain tokens from API, doesn't leak that information to external links. (Including links in
<head>section, CSS files etc.)